Re: [gaim-bnet-devel] gaim_normalize()... really needed?

[Gary K. <gr...@re...>]

On Thu, 2005-01-13 at 12:21 +0000, evew wrote:
> I found a bug inside bnet_buddy_add() in a wrong use of gaim_normalize=20
> ():
>=20
> name =3D gaim_normalize(conn->account, buddy->name);
>=20
> Using name for saving our buddy inside the hash table is wrong 'cause =20
> gaim_normalize() returns a pointer to a own static array... then its =20
> value isn't the same during time :P
>=20
> As a result of this when receiving friends list all buddy are =20
> considered new (because not found in conn->buddies) then (re)added in =20
> the gaim list... resulting in a big increasing of our popolarity in a =20
> few seconds :)
>=20
> Anyway, I was thinking about the needing of this line... 'cause if it's =20
> useful, then we can simply g_strdup() name, but we are already using =20
> gaim_utf8_strcasecmp() to compare nicks in the hash table... isn't =20
> enough?
>=20
> cya

I thought we were strcmp'n it which would make that legit.. But if we're
just comparing pointers, than yeah thats going to be a problem...


--=20
Gary Kramlich <gr...@re...>