Re: [fuse-devel] Why did fuse_file_info changed from unsigned long to uint64_t in fuse-2.5?

[Miklos S. <mi...@sz...>]

> I just got some compile warnings in my code about making casts from
> pointer to integer of different size because it was changed from
> unsigned long to uint64_t, wich will obviously cause problems in arch
> where pointers are not 64bits.
> 
> 
> What was the reasoning in the change?

The reason was that in some cases it's useful to have a 64 bit value
and the kernel interface already has it.

> I see we have an old_fh member there now.

That's just for binary compatibility.  It should be ignored.

> For now I solved the warnings with extra casts (void *)((long)fi->fh).

OK, but keep in mind that there shouldn't be more than two such
places: the inline functions used for storing and retrieving fi->fh.
Having casts all over the place is ugly and not type-safe.

Miklos