Re: [fuse-devel] [PATCH v2] fuse: allocate for_background dio requests based on io->async state

[Maxim P. <mpa...@pa...>]

Hi Miklos,

05/15/2013 12:43 PM, Miklos Szeredi пишет:
> On Tue, May 14, 2013 at 5:25 PM, Brian Foster <bf...@re...> wrote:
>> Commit 8b41e671 introduced explicit background checking for fuse_req
>> structures with BUG_ON() checks for the appropriate type of request in
>> in the associated send functions. Commit bcba24cc introduced the ability
>> to send dio requests as background requests but does not update the
>> request allocation based on the type of I/O request. As a result, a
>> BUG_ON() triggers in the fuse_request_send_background() background path if
>> an async I/O is sent.
>>
>> Allocate a request based on the async state of the fuse_io_priv to avoid
>> the BUG.
>>
>> Signed-off-by: Brian Foster <bf...@re...>
>> ---
>> v2:
>> - Fix up the second fuse_get_req*() call in fuse_direct_io(). Thanks for catching
>>    that Miklos.
>
> Applied, thanks.

I've just noticed you applied it to 'for-next' branch, not 'for-linus'. 
Why? I thought, given FUSE_ASYNC_DIO is already in v3.10-rc*, we have to 
stabilize this feature in Linus' tree...

Thanks,
Maxim