Re: [fuse-devel] FORGET for create, mkdir, etc?

[Goswin v. B. <gos...@we...>]

Nikolaus Rath <Nik...@ra...> writes:

> @@ -307,6 +323,11 @@
>  
>  	/**
>  	 * Remove a file
> +         *
> +	 * If the file's inode's lookup count is non-zero, the file
> +	 * system is expected to postpone any removal of the inode
> +	 * until the lookup count reaches zero (see description of the
> +	 * forget function).
>  	 *
>  	 * Valid replies:
>  	 *   fuse_reply_err

Are you sure about that?

If I properly use inode generation numbers and set and use fi->fh in all
callbacks having "struct fuse_file_info *fi" then what stops me from
removing and even reusing an inode that is still opened let alone looked
up.

> @@ -346,6 +372,12 @@
>  
>  	/** Rename a file
>  	 *
> +	 * If the target exists it should be overwritten. If the

If the target exists it should be atomically replaced.

> +	 * target's inode's lookup count is non-zero, the file system
> +	 * is expected to postpone any removal of the inode until the
> +	 * lookup count reaches zero (see description of the forget
> +	 * function).
> +         *
>  	 * Valid replies:
>  	 *   fuse_reply_err
>  	 *

Other than the "pospone" parts this looks good.

MfG
        Goswin