If the intent is only to show a summary of user-selectable configure options I don't think so, but I think of those bits as code variations that may not be obvious.
No need to add them if you don't think it would be useful.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
The main reason why I want to print that is that I want to know what features I'm enabling when I build Fuse.
This is useful for distributors (I'm maintaining the Debian packages). With this it's easy to see if all the compilation flags and dependencies are in place, and therefore the packages that users get are not missing any feature.
Whether Fuse uses SDL_Delay(), Sleep() or usleep() is an implementation detail that is not useful for me, to be honest. I have no problem to add it if you think it's important. There's also other bits of information that we could add (and are more important in my opinion), such as the installation path ($prefix) or the ROMs directory. I just decided to have the most important things in my initial patch.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
--- old+++ new@@ -1,3 +1,7 @@+++-----+
This is similar to [#376], but for Fuse.
Fuse is more complex to build so I might have overlooked something, and I certainly haven't tested all available settings (Wii, win32, ...).
--- old+++ new@@ -1,7 +1,3 @@---------
This is similar to [#376], but for Fuse.
Fuse is more complex to build so I might have overlooked something, and I certainly haven't tested all available settings (Wii, win32, ...).
Looks good to me at first glance. Maybe you could add the timer and compat routines being used?
Is it worth it? Those are things the user has no control of, and they don't have any effect on user-visible features, or do they?
If the intent is only to show a summary of user-selectable configure options I don't think so, but I think of those bits as code variations that may not be obvious.
No need to add them if you don't think it would be useful.
The main reason why I want to print that is that I want to know what features I'm enabling when I build Fuse.
This is useful for distributors (I'm maintaining the Debian packages). With this it's easy to see if all the compilation flags and dependencies are in place, and therefore the packages that users get are not missing any feature.
Whether Fuse uses SDL_Delay(), Sleep() or usleep() is an implementation detail that is not useful for me, to be honest. I have no problem to add it if you think it's important. There's also other bits of information that we could add (and are more important in my opinion), such as the installation path ($prefix) or the ROMs directory. I just decided to have the most important things in my initial patch.
That's fine - I've no objection to you just including what you want.
Looks good to me. The windows UI don't need special features and the wii UI is broken. Here are some suggestions,
Alter the order to put Fuse options at the end. They seem to be more important and need less scroll:
I've also noted more wording than libspectrum for the status:
instead of:
More words means more text to read, makes difficult checking at a glance.
Finally, are the parameter expansions a bashism? (too much tired to check it)
${LIBSPEC_HAVE_ZLIB:-no}
Last edit: Sergio Baldoví 2016-08-16
Ok
They're not
http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_06_02
Diff:
Related
Patches:
#376Thanks, committed in [r5766].
Related
Commit: [r5766]
Diff:
Related
Patches:
#376