Menu

#378 Print summary of enabled features when building Fuse

v1.3.0
closed-accepted
nobody
autoconf (3)
5
2016-10-02
2016-08-16
No

This is similar to [#376], but for Fuse.

Fuse is more complex to build so I might have overlooked something, and I certainly haven't tested all available settings (Wii, win32, ...).

1 Attachments

Related

Patches: #376
Patches: #379

Discussion

  • Fredrick Meunier

    Looks good to me at first glance. Maybe you could add the timer and compat routines being used?

    checking which timer routines to use... native
    checking which compatibility routines to use... unix
    
     
    • Alberto Garcia

      Alberto Garcia - 2016-08-16

      Is it worth it? Those are things the user has no control of, and they don't have any effect on user-visible features, or do they?

       
  • Fredrick Meunier

    If the intent is only to show a summary of user-selectable configure options I don't think so, but I think of those bits as code variations that may not be obvious.

    No need to add them if you don't think it would be useful.

     
    • Alberto Garcia

      Alberto Garcia - 2016-08-16

      The main reason why I want to print that is that I want to know what features I'm enabling when I build Fuse.

      This is useful for distributors (I'm maintaining the Debian packages). With this it's easy to see if all the compilation flags and dependencies are in place, and therefore the packages that users get are not missing any feature.

      Whether Fuse uses SDL_Delay(), Sleep() or usleep() is an implementation detail that is not useful for me, to be honest. I have no problem to add it if you think it's important. There's also other bits of information that we could add (and are more important in my opinion), such as the installation path ($prefix) or the ROMs directory. I just decided to have the most important things in my initial patch.

       
  • Fredrick Meunier

    That's fine - I've no objection to you just including what you want.

     
  • Sergio Baldoví

    Sergio Baldoví - 2016-08-16

    Looks good to me. The windows UI don't need special features and the wii UI is broken. Here are some suggestions,

    Alter the order to put Fuse options at the end. They seem to be more important and need less scroll:

    libspectrum features
    ...
    fuse options
    ...
    Type 'make' to compile Fuse
    

    I've also noted more wording than libspectrum for the status:

    zlib support enabled: yes
    

    instead of:

    zlib support: yes
    

    More words means more text to read, makes difficult checking at a glance.

    Finally, are the parameter expansions a bashism? (too much tired to check it)
    ${LIBSPEC_HAVE_ZLIB:-no}

     

    Last edit: Sergio Baldoví 2016-08-16
  • Sergio Baldoví

    Sergio Baldoví - 2016-08-21
    • labels: --> autoconf
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1,3 +1,7 @@
    +
    +
    +-----
    +
     This is similar to [#376], but for Fuse.
    
     Fuse is more complex to build so I might have overlooked something, and I certainly haven't tested all available settings (Wii, win32, ...).
    
    • status: open --> pending-accepted
     

    Related

    Patches: #376

  • Sergio Baldoví

    Sergio Baldoví - 2016-08-21

    Thanks, committed in [r5766].

     

    Related

    Commit: [r5766]

  • Sergio Baldoví

    Sergio Baldoví - 2016-08-21
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1,7 +1,3 @@
    -
    -
    ------
    -
     This is similar to [#376], but for Fuse.
    
     Fuse is more complex to build so I might have overlooked something, and I certainly haven't tested all available settings (Wii, win32, ...).
    
     

    Related

    Patches: #376

  • Fredrick Meunier

    • Group: future --> NextRelease
     
  • Fredrick Meunier

    • status: pending-accepted --> closed-accepted
     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.