#373 DISCiPLE and +D subpages not coalesced

[Sergio Baldoví]

Related to [bugs:#347], looks odd to me that DISCiPLE and +D RAM pages are not summarised like the ROM pages.

fuse --disciple --debugger-command "tbreak event disciple:page"

ADDRESS	SOURCE	WRITABLE	CONTENDED
0x0000	DISCiPLE ROM 0	N	N
0x2000	DISCiPLE RAM 0	Y	N
0x2800	DISCiPLE RAM 0	Y	N
0x3000	DISCiPLE RAM 0	Y	N
0x3800	DISCiPLE RAM 0	Y	N

I think we are failing to set the subpage offset for the DISCiPLE RAM page:

/* We expect the next page to have an increased offset */
offset += MEMORY_PAGE_SIZE;

The coalesced subpages should look like:

ADDRESS	SOURCE	WRITABLE	CONTENDED
0x0000	DISCiPLE ROM 0	N	N
0x2000	DISCiPLE RAM 0	Y	N

The same happens for +D, but in this case I think we should use different memory sources too, like DISCiPLE:

fuse --plusd --debugger-command "tbreak event plusd:page"

actual:

ADDRESS	SOURCE	WRITABLE	CONTENDED
0x0000	PlusD 0	N	N
0x2000	PlusD 0	Y	N
0x2800	PlusD 0	Y	N
0x3000	PlusD 0	Y	N
0x3800	PlusD 0	Y	N

expected:

ADDRESS	SOURCE	WRITABLE	CONTENDED
0x0000	PlusD ROM 0	N	N
0x2000	PlusD RAM 0	Y	N

[Sergio Baldoví]

I'll commit this for the next release, barring objections.

[Sergio Baldoví]

Committed in [r5671].