Menu

#354 Make libspectrum make-perl compilation cross-compile friendly

v1.2
closed-accepted
nobody
None
5
2016-06-06
2016-04-09
No

Make libspectrum make-perl compilation cross-compile friendly. Changes from BogDan Vatra in [#349].

1 Attachments

Related

Patches: #349

Discussion

  • Fredrick Meunier

    This patch is effectively a revert of [r4731] from [bugs:#262].

    Sergio: you introduced that to suppress a Debian warning about use of hardened build flags, do you still think that the Debian flags should be used in the cross-compilation case?

    BogDan: Could you give some more details on the cross-compile failure that this patch fixes?

     

    Related

    Bugs: #262
    Commit: [r4731]

    • Sergio Baldoví

      Sergio Baldoví - 2016-04-09

      I think BogDan is using CFLAGS for setting up the arch, that would prevent running make_perl in the build machine.

      IMO this patch is better than the current state. We could set the hardening flags in Debian by adding CFLAGS_FOR_BUILD.

      Anyway, the use makeperl for cross compiling is flawed without stdint.h. I still hope that makeperl will be removed before the next release.

       

      Last edit: Sergio Baldoví 2016-04-09
  • BogDan Vatra

    BogDan Vatra - 2016-04-09

    I think Sergio answered for me. When compiling for Android I need to set Android specific CFLAGS (check https://github.com/bog-dan-ro/spectacol/blob/master/build/android.sh) which doesn't work for host tools :)

     
  • Fredrick Meunier

    • status: open --> pending-accepted
    • Group: future --> v1.2
     
  • Fredrick Meunier

    Thanks, committed in [r5381].

     

    Related

    Commit: [r5381]

  • Fredrick Meunier

    • status: pending-accepted --> closed-accepted
     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.