Does anyone have any concerns about applying this patch? I'm comfortable with it, though I do think that we may miss maintaining the extern "C" usage as headers are changed/introduced in the future as it isn't required in the core codebase.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
You can specify C linkage in the C++ code that includes the C headers, so I suggest that is the best place for handling that for now as I don't think that the developers working on Fuse in C will be in a good position to maintain the C++ compatibility over time.
I've removed utils_make_temp_file() which had the keyword clash with C++ as it isn't needed anymore in any case which should help.
If anyone else has a strong opinion, please speak up!
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Does anyone have any concerns about applying this patch? I'm comfortable with it, though I do think that we may miss maintaining the extern "C" usage as headers are changed/introduced in the future as it isn't required in the core codebase.
Without this change it is impossible by any C++ UI to use libspectrum or FUSE.
You can specify C linkage in the C++ code that includes the C headers, so I suggest that is the best place for handling that for now as I don't think that the developers working on Fuse in C will be in a good position to maintain the C++ compatibility over time.
I've removed utils_make_temp_file() which had the keyword clash with C++ as it isn't needed anymore in any case which should help.
If anyone else has a strong opinion, please speak up!