Menu

#353 Make Fuse headers C++ friendly

future
open
nobody
None
5
2016-06-09
2016-04-09
No

Make Fuse headers C++ friendly by using extern "C" and changing C++ reserved words. Changes from BogDan Vatra in [#349].

1 Attachments

Related

Patches: #349

Discussion

  • Fredrick Meunier

    Does anyone have any concerns about applying this patch? I'm comfortable with it, though I do think that we may miss maintaining the extern "C" usage as headers are changed/introduced in the future as it isn't required in the core codebase.

     
  • BogDan Vatra

    BogDan Vatra - 2016-04-09

    Without this change it is impossible by any C++ UI to use libspectrum or FUSE.

     
  • Fredrick Meunier

    You can specify C linkage in the C++ code that includes the C headers, so I suggest that is the best place for handling that for now as I don't think that the developers working on Fuse in C will be in a good position to maintain the C++ compatibility over time.

    I've removed utils_make_temp_file() which had the keyword clash with C++ as it isn't needed anymore in any case which should help.

    If anyone else has a strong opinion, please speak up!

     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.