Fuse - the Free Unix Spectrum Emulator / Patches / #349 Spectacol's changes

Fredrick Meunier - 2016-04-09

I've been adding single patches artifacts for these to process them.

I've added [#354] for 0003-Be-cross-compile-friendly.patch and added a question for you, could you please answer it there?

Related

Patches: ~~#354~~

Last edit: Fredrick Meunier 2016-04-09

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Fredrick Meunier - 2016-06-06

Group: v1.2 --> future
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Fredrick Meunier - 2016-06-08

Hi BogDan,
If you get a chance, can you please comment on the queries in [patches:#356] Make libspectrum thread-safe?

Related

Patches: ~~#356~~

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- BogDan Vatra - 2016-06-09
  
  Yes, I'll do it in a moment
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Removing 0003-Be-cross-compile-friendly.patch as it is addressed in [patches:#354]

- Attachments has changed:

Diff:

--- old
+++ new
@@ -1,6 +1,5 @@
 0001-Be-C-friendly.patch (21.0 kB; text/x-patch)
 0002-use-compat_file_exists-intread-of-stat.patch (1.8 kB; text/x-patch)
-0003-Be-cross-compile-friendly.patch (874 Bytes; text/x-patch)
 0004-Make-fuse-a-stand-alone-library-move-main-entry-poin.patch (15.1 kB; text/x-patch)
 0005-make-libspectrum-thread-safe.patch (308.6 kB; text/x-patch)
 0006-Process-only-the-UI-events-if-paused.patch (778 Bytes; text/x-patch)

Patches: ~~#354~~

Last edit: Fredrick Meunier 2016-06-08

Removing 0008-Fix-JP-HL-IX-IY-disassemble-string.patch as it is addressed in [patches:#350]

Attachments has changed:

Diff:

--- old
+++ new
@@ -4,7 +4,6 @@
 0005-make-libspectrum-thread-safe.patch (308.6 kB; text/x-patch)
 0006-Process-only-the-UI-events-if-paused.patch (778 Bytes; text/x-patch)
 0007-Signal-the-UI-when-the-breakpoints-list-is-changed.patch (3.9 kB; text/x-patch)
-0008-Fix-JP-HL-IX-IY-disassemble-string.patch (895 Bytes; text/x-patch)
 0009-exit-event-loop-when-hitting-a-breakpoint.patch (848 Bytes; text/x-patch)
 0010-Fix-error.patch (641 Bytes; text/x-patch)
 0011-Fix-compilation-on-Android.patch (1.6 kB; text/x-patch)

Patches: ~~#350~~

Last edit: Fredrick Meunier 2016-06-08

Attachments has changed:

Diff:

--- old
+++ new
@@ -1,5 +1,4 @@
 0001-Be-C-friendly.patch (21.0 kB; text/x-patch)
-0002-use-compat_file_exists-intread-of-stat.patch (1.8 kB; text/x-patch)
 0004-Make-fuse-a-stand-alone-library-move-main-entry-poin.patch (15.1 kB; text/x-patch)
 0005-make-libspectrum-thread-safe.patch (308.6 kB; text/x-patch)
 0006-Process-only-the-UI-events-if-paused.patch (778 Bytes; text/x-patch)

Fredrick Meunier - 2016-06-08

Removing 0002-use-compat_file_exists-intread-of-stat.patch and 0012-Fix-settings-file-lookup.patch as they are addressed in [patches:#351]

Attachments has changed:

Diff:

--- old +++ new @@ -6,5 +6,4 @@ 0009-exit-event-loop-when-hitting-a-breakpoint.patch (848 Bytes; text/x-patch) 0010-Fix-error.patch (641 Bytes; text/x-patch) 0011-Fix-compilation-on-Android.patch (1.6 kB; text/x-patch) -0012-Fix-settings-file-lookup.patch (705 Bytes; text/x-patch) 0013-Fix-sound-on-Android.patch (1.6 kB; text/x-patch)

Related

Patches: ~~#351~~

Last edit: Fredrick Meunier 2016-06-08
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Removing 0010-Fix-error.patch as it is addressed in [patches:#352]

Attachments has changed:

Diff:

--- old
+++ new
@@ -4,6 +4,5 @@
 0006-Process-only-the-UI-events-if-paused.patch (778 Bytes; text/x-patch)
 0007-Signal-the-UI-when-the-breakpoints-list-is-changed.patch (3.9 kB; text/x-patch)
 0009-exit-event-loop-when-hitting-a-breakpoint.patch (848 Bytes; text/x-patch)
-0010-Fix-error.patch (641 Bytes; text/x-patch)
 0011-Fix-compilation-on-Android.patch (1.6 kB; text/x-patch)
 0013-Fix-sound-on-Android.patch (1.6 kB; text/x-patch)

Patches: ~~#352~~

Last edit: Fredrick Meunier 2016-06-08

Removing 0007-Signal-the-UI-when-the-breakpoints-list-is-changed.patch as it is addressed in [patches:#357]

Attachments has changed:

Diff:

--- old
+++ new
@@ -2,7 +2,6 @@
 0004-Make-fuse-a-stand-alone-library-move-main-entry-poin.patch (15.1 kB; text/x-patch)
 0005-make-libspectrum-thread-safe.patch (308.6 kB; text/x-patch)
 0006-Process-only-the-UI-events-if-paused.patch (778 Bytes; text/x-patch)
-0007-Signal-the-UI-when-the-breakpoints-list-is-changed.patch (3.9 kB; text/x-patch)
 0009-exit-event-loop-when-hitting-a-breakpoint.patch (848 Bytes; text/x-patch)
 0011-Fix-compilation-on-Android.patch (1.6 kB; text/x-patch)
 0013-Fix-sound-on-Android.patch (1.6 kB; text/x-patch)

Patches: ~~#357~~

Last edit: Fredrick Meunier 2016-06-08

Fredrick Meunier - 2016-06-08

I think 0009-exit-event-loop-when-hitting-a-breakpoint.patch is no longer relevant.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- BogDan Vatra - 2016-06-09
  
  Why not?
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
  - Fredrick Meunier - 2016-06-09
    
    Because since [r5556] we don't make debugger_check() conditional on the z80 not being halted - do you find it is still neccessary since 1.2.0?
    
    $ svn diff -c 5556 Index: hacking/ChangeLog =================================================================== --- hacking/ChangeLog (revision 5555) +++ hacking/ChangeLog (revision 5556) @@ -5177,3 +5177,6 @@ 20160529 README,man/fuse.1: update release dates (Fred). 20160529 configure.ac: mark release as 1.2.0-pre1 (Fred). 20160530 configure.ac: update more copyright dates (Sergio). +20160530 z80/z80_ops.c: revert don't trap on breakpoints whilst halted in + [r5171] as it contributes to [bugs:316] and there is no current + resolution (Fred). Index: z80/z80_ops.c =================================================================== --- z80/z80_ops.c (revision 5555) +++ z80/z80_ops.c (revision 5556) @@ -161,7 +161,7 @@ /* Check if the debugger should become active at this point */ CHECK( debugger, debugger_mode != DEBUGGER_MODE_INACTIVE ) - if( !z80.halted && debugger_check( DEBUGGER_BREAKPOINT_TYPE_EXECUTE, PC ) ) + if( debugger_check( DEBUGGER_BREAKPOINT_TYPE_EXECUTE, PC ) ) debugger_trap(); END_CHECK
    
    Related
    
    Commit: [r5171]
    Commit: [r5556]
    
    If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
    - BogDan Vatra - 2016-06-09
      
      Right, but I break the while in that moment, othewise it go to the next instrction.
      Anyway I'll double check tonight to see if I can reproduce the problem without my patch.
      
      If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
      - Fredrick Meunier - 2016-06-09
        
        I think I've missed the point of the patch and now I'm not so sure the change was relevant, however if I put a breakpoint on address 0x0000 and do a RANDOMIZE USR 0 I break into the debugger at PC 0x0000 as expected so I'm not clear on how it gets to the next instruction in your case.
        
        If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
        
        BogDan Vatra - 2016-06-09
        
        IIRC it happened on break on write (or on read) breakpoints...
        
        If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
        
        BogDan Vatra - 2016-06-09
        
        It seems to wrok ok without it ..., so yes, you can drop it :)
        
        If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
        
        Fredrick Meunier - 2016-06-09
        
        Good news :)
        
        If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Fredrick Meunier - 2016-06-09

Removing 0001-Be-C-friendly.patch as it is being handled under [patches:#353].

Attachments has changed:

Diff:

--- old +++ new @@ -1,4 +1,3 @@ -0001-Be-C-friendly.patch (21.0 kB; text/x-patch) 0004-Make-fuse-a-stand-alone-library-move-main-entry-poin.patch (15.1 kB; text/x-patch) 0005-make-libspectrum-thread-safe.patch (308.6 kB; text/x-patch) 0006-Process-only-the-UI-events-if-paused.patch (778 Bytes; text/x-patch)

Related

Patches: #353

Last edit: Fredrick Meunier 2016-06-09
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Fredrick Meunier - 2016-06-09

Removing 0004-Make-fuse-a-stand-alone-library-move-main-entry-poin.patch as it is being handled under [patches:#355].

Attachments has changed:

Diff:

--- old +++ new @@ -1,4 +1,3 @@ -0004-Make-fuse-a-stand-alone-library-move-main-entry-poin.patch (15.1 kB; text/x-patch) 0005-make-libspectrum-thread-safe.patch (308.6 kB; text/x-patch) 0006-Process-only-the-UI-events-if-paused.patch (778 Bytes; text/x-patch) 0009-exit-event-loop-when-hitting-a-breakpoint.patch (848 Bytes; text/x-patch)

Related

Patches: #355

Last edit: Fredrick Meunier 2016-06-09
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Fredrick Meunier - 2016-06-09

Removing 0005-make-libspectrum-thread-safe.patch as it is being handled under [patches:#356].

Attachments has changed:

Diff:

--- old +++ new @@ -1,4 +1,3 @@ -0005-make-libspectrum-thread-safe.patch (308.6 kB; text/x-patch) 0006-Process-only-the-UI-events-if-paused.patch (778 Bytes; text/x-patch) 0009-exit-event-loop-when-hitting-a-breakpoint.patch (848 Bytes; text/x-patch) 0011-Fix-compilation-on-Android.patch (1.6 kB; text/x-patch)

Related

Patches: ~~#356~~

Last edit: Fredrick Meunier 2016-06-09
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Fredrick Meunier - 2016-06-09

Removing 0006-Process-only-the-UI-events-if-paused.patch as it is being handled under [patches:#370].

Attachments has changed:

Diff:

--- old +++ new @@ -1,4 +1,3 @@ -0006-Process-only-the-UI-events-if-paused.patch (778 Bytes; text/x-patch) 0009-exit-event-loop-when-hitting-a-breakpoint.patch (848 Bytes; text/x-patch) 0011-Fix-compilation-on-Android.patch (1.6 kB; text/x-patch) 0013-Fix-sound-on-Android.patch (1.6 kB; text/x-patch)

Related

Patches: #370

Last edit: Fredrick Meunier 2016-06-09
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Fredrick Meunier - 2016-06-09
  
  Hi BogDan,
  I've started a followup discussion in [patches:#370].
  
  Related
  
  Patches: #370
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Fredrick Meunier - 2016-06-09

Removing 0011-Fix-compilation-on-Android.patch as it is being handled under [patches:#371].

Attachments has changed:

Diff:

--- old +++ new @@ -1,3 +1,2 @@ 0009-exit-event-loop-when-hitting-a-breakpoint.patch (848 Bytes; text/x-patch) -0011-Fix-compilation-on-Android.patch (1.6 kB; text/x-patch) 0013-Fix-sound-on-Android.patch (1.6 kB; text/x-patch)

Related

Patches: #371

Last edit: Fredrick Meunier 2016-06-09
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Fredrick Meunier - 2016-06-09
  
  Follow-up queries under [patches:#371].
  
  Related
  
  Patches: #371
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Spectacol's changes

Group

Searches

Help

#349 Spectacol's changes

Related

Discussion

Related

Related

Related

Related

Related

Related

Related

Related

Related

Related

Related

Related

Related

Related

Related