Re: [fuse-emulator-devel] Removal of deprecated `gdk_display_get_default` function

[Philip K. <ph...@sh...>]

On Sun, Feb 18, 2024 at 11:09 AM Alberto Garcia <be...@ig...> wrote:

> On Sun, Feb 18, 2024 at 09:38:10AM +0000, Philip Kendall wrote:
> > Hey, I actually wrote some code!
> >
> >
> https://sourceforge.net/p/fuse-emulator/fuse/ci/patch-440-remove-gdk_keymap_get_default/tree/
> >
> > Given I can't remember how any of this works :( if anyone wants to
> > look it over and tell me if I've broken anything that would be much
> > appreciated!
>
> Hi, the patch looks fine to me, but I don't think you strictly need
> the global gtkui_default_display variable... gdk_display_get_default()
> simply returns
>
>    manager->default_display
>
> so you're not saving a lot here by caching the result.
>

Agreed, simpler version without caching now merged.

Thanks!

Phil