Re: [fuse-emulator-devel] [fuse-emulator-cvs] [libspectrum] branch master updated: Updates for a "1.5.0" release

[Alberto G. <be...@ig...>]

On Fri, Feb 12, 2021 at 10:43:44PM +1100, Fredrick Meunier wrote:
> >> ## * Always increase the revision value.
> >> ## * Increase the age value only if the changes made to the ABI are backward
> >> ##   compatible.
> >> -libspectrum_la_LDFLAGS = -version-info 16:14:8 -no-undefined @WINDRES_LDFLAGS@
> >> +libspectrum_la_LDFLAGS = -version-info 17:15:8 -no-undefined @WINDRES_LDFLAGS@
> > 
> > Do you think a soname dump is required?
> > 
> > I was expecting an increase of the age value too.
> 
> Hmm I did do an api compatibility check to decide on the appropriate
> values (see attached) and it reported that both source and binary
> compatibility has been affected by the changes.
> 
> The source isn’t 100% compatible due to the removal of
> libspectrum_snap_alloc_internal() which isn’t supposed to be part
> of the public API but is still being flagged.

I don't think that breaks source compatibility, the report is probably
because the symbol is exported in the .so file even though it is not
part of the public API.

We could hide those private symbols in this or in a future release.

> Binary compatibility is affected by the changes to the
> libspectrum_snap structure.so its a deliberate choice to not bump
> the age value.

But that's an internal structure, as far as I can see users of the
library can only see an opaque pointer.

Did you notice any compatibility problem?

Berto