Re: [fuse-emulator-devel] [fuse-emulator-cvs] [libspectrum] branch master updated: Updates for a "1.5.0" release

[Sergio B. <ser...@gm...>]

Hi Fred,

On 12/2/21 12:43, Fredrick Meunier wrote:
>> On 12 Feb 2021, at 17:41, Sergio Baldoví <ser...@gm...> wrote:
>>
>> Do you think a soname dump is required?
>>
>> I was expecting an increase of the age value too.
> 
> Hmm I did do an api compatibility check to decide on the appropriate values (see attached) and it reported that both source and binary compatibility has been affected by the changes.
> 
> The source isn’t 100% compatible due to the removal of libspectrum_snap_alloc_internal() which isn’t supposed to be part of the public API but is still being flagged.
> 
> Binary compatibility is affected by the changes to the libspectrum_snap structure.so its a deliberate choice to not bump the age value.
> 
> Have I made a mistake?

I've also run abi-compliance-checker and get a 100% compatibility (see
attachment).

The main difference is that I run it on the installed libspectrum tree
[1][2] rather than the build tree, so I guess that it only takes into
account public headers/interfaces.

Honestly I'm not sure about the scope of these changes so I'm happy to
keep your choice.

I'll also commit patch #411 to benefit from this choice.

Cheers,
Sergio

[1] https://sourceware.org/glibc/wiki/Testing/ABI_checker
[2]
https://fedoraproject.org/wiki/How_to_check_for_ABI_changes_with_abi_compliance_checker