Menu

libspectrum Merge Request #13: fix: Fixed running unittest checks which require gzip, but gzip was not enabled or available. (merged)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

Arki55 wants to merge 1 commit from /u/arki55/libspectrum/ to master, 2023-08-21

From all the various build variants I configured within GitHub build workflows,
some of them were failing due to missing GZIP library.

Gzip is used for saving and loading of some block types of SZX snapshot format.
Tests testing operations on these blocks fail with error message that gzip is not present. Plus there was a SIGTERM due to a bug accessing page 85, while memory was reserved for 64.

This needs to be patched, so that all build variants of Libspectrum work correctly.

See
https://sourceforge.net/p/arki55-fuse-mod/tickets/10/

All checks now green in GitHub checks
https://github.com/arki55/fuse-libspectrum/pull/6/checks
https://github.com/arki55/fuse-libspectrum/pull/12/checks

Commit Date  
[56e6f8] (arki55/features/T10-github-builds-no-gzip-final) by Miroslav Ďurčík Miroslav Ďurčík , pushed by GitHub GitHub

fix: Fixed running unittest checks which require gzip, but gzip was not enabled or available.

fix: Fixed running unittest checks which require gzip, but gzip was not enabled or available. In case of writing block, uncompressed size will be checked. In case of reading gzipped files, such tests will be skipped.

fix: Fixed core dump in test 39, when 85 (0x55) pages where to be saved, while memory was reserverd for 64.
refactor: Internal function for executing such test was modified to return error code in case more pages requested than actually reserved in memory.

unittest: Added support for returning TEST_SKIPPED as return value from test function.


See also https://sourceforge.net/p/arki55-fuse-mod/tickets/10/

2023-04-25 20:12:25 Tree

Discussion

  • Arki55

    Arki55 - 2023-08-15

    Any possibility of merging this ?

     
  • Sergio Baldoví

    Sergio Baldoví - 2023-08-21

    Sure. Merged in [8b374c]. Thank you.

     

    Related

    Commit: [8b374c]

  • Sergio Baldoví

    Sergio Baldoví - 2023-08-21
    • Status: open --> merged
     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.