libspectrum Merge Request #10: Arki55 :: T10 Libspectrum :: GitHub build checks :: Fix when GZIP not enabled (rejected)
Merging...
Merged
Something went wrong. Please, merge manually
Checking if merge is possible...
Something went wrong. Please, merge manually
Arki55 wants to merge 5 commits from /u/arki55/libspectrum/ to master, 2023-04-25
From all the various build variants I configured within GitHub build workflows,
some of them were failing due to missing GZIP library.
Gzip is used for saving and loading of some block types of SZX snapshot format.
Tests testing operations on these blocks fail with error message that gzip is not present. Plus there was a SIGTERM due to a bug accessing page 85, while memory was reserved for 64.
This needs to be patched, so that all build variants of Libspectrum work correctly.
See
https://sourceforge.net/p/arki55-fuse-mod/tickets/10/
All checks now green in GitHub checks
https://github.com/arki55/fuse-libspectrum/pull/6/checks
| Commit | Date | |
|---|---|---|
|
[165a75]
(arki55/features/T10-github-builds-no-gzip)
by
Miroslav Ďurčík / Arki55
arki55/features/T10-github-builds-no-gzip chore: Corrected printf parameter as hinted by Sergio Baldovi. |
2023-04-15 15:23:02 | Tree |
|
[e7a826]
by
Miroslav Durcik / Arki55
arki55/features/T10-github-builds-no-gzip |
2023-04-03 20:13:20 | Tree |
| 2023-03-24 22:47:52 | Tree | |
|
[512768]
by
Miroslav Ďurčík / Arki55
fix: Added error constant to correct file. libspectrum.h is generated. |
2023-03-24 22:37:50 | Tree |
|
[82640f]
by
Miroslav Ďurčík / Arki55
T10-github-builds-no-gzip fix: Fixed running unittest checks which require gzip, but gzip was not enabled or available. In case of writing block, uncompressed size will be checked. In case of reading gzipped files, such tests will be skipped. |
2023-03-24 22:17:39 | Tree |
Thank you. Looks good to me.
I wouldn't use the %zu printf modifier as libspectrum (and the core of Fuse) sticks to C89. It's preferable to use %lu and cast to unsigned long as other parts of the code.
Thanks, I've corrected it.
Superseded by
https://sourceforge.net/p/fuse-emulator/libspectrum/merge-requests/13/