#494 ZX Spectrum icons don't appear in the file chooser

[Alberto Garcia]

I can reproduce this in Debian stable and unstable, and also with Fuse from Flatpak. Open a file browser (or a file chooser from Fuse) and go to a directory with ZX Spectrum files. Instead of the expected Spectrum icon you'll see a generic blank one.

[Alberto Garcia]

This patch solves the problem for me.

See here for a related bug: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2190

[Sergio Baldoví]

Thank you. Committed in [9f5593] slightly modified with recent .s file extension.

[Alberto Garcia]

On second thoughts I wonder if it's fine to use the ZX Spectrum icon for extensions like .img, .raw or .rom, which are very generic and can have any content, really.

[Sergio Baldoví]

On second thoughts I wonder if it's fine to use the ZX Spectrum icon for extensions like .img, .raw or .rom, which are very generic and can have any content, really.

Good question. I don't mind drop them from the mime list as they are not Spectrum specific. Opinions?

On Windows we associate the most common file extensions (.tzx, .tap, pzx, .szx, .z80, .sna and .rzx). Techy users can associate other file extensions via windows file explorer.

[Alberto Garcia]

I don't think it makes sense to open ROM files directly, it's not like a tape or snapshot which the emulator can load automatically. And .img and .raw files can be anything, really. So I would only keep those that are actually ZX Spectrum formats.

[Sergio Baldoví]

Thank you. Fixed in [adf05c].

[Alberto Garcia]

It looks like the compressed versions (*.raw.bz2, *.img.gz, ...) are still there. But before removing those I would take a closer look at the full list, I'm not sure that things like .csw should have the ZX Spectrum icon.

I think that I would reduce that list to the extensions that Fuse can open directly if you run it with fuse <filename>, and maybe for the bash completion script we can keep some additional extensions.

[Sergio Baldoví]

It looks like the compressed versions (*.raw.bz2, *.img.gz, ...) are still there.

D'oh! I missed that.

But before removing those I would take a closer look at the full list, I'm not sure that things like .csw should have the ZX Spectrum icon.

Do you mind reviewing the file extensions list? .csw is mainly used for ZX Spectrum (and Amstrad?), but Corel Wordperfect also use that file extension. On Windows the last installed program usually takes control on supported extensions. But in case of doubt we can go without the icon as we do with .wav.

I think that I would reduce that list to the extensions that Fuse can open directly if you run it with fuse <filename>,

Seems a good strategy. Have a look to utils_open_file() to check what kind of files are supported.

and maybe for the bash completion script we can keep some additional extensions.

It will likely worth the full list here. Bash completion list files that the user can choose. In a folder of a ZX enthusiast you will likely found ZX content. It behaves similar to the GTK fileselector filters.

[Alberto Garcia]

Ok, so Fuse can actually open a lot of files if you pass them directly through the command line, so I decided to only keep the common ones (like in Windows, plus a couple more) and I expect that advanced users can figure out how to open the rest.

The list is: .dsk, .pzx, .rzx, .slt, .sna, .szx, .tap, .tzx and .z80

The bash completion still supports all formats, I don't think it's necessary to reduce that list.

Tell me what you think.