Menu

#442 hq3x scaler is not redrawing properly

v1.6.0
closed-fixed
scaler (2)
5
2021-02-28
2018-12-26
No

The HQ 3x scaler is not redrawing properly and leaves some "junk" behind. For an example, start Head over Heels then press "up" (Q by default). Note how the floor behind Head is corrupted - see attachment. The corruption goes away if something forces an entire screen redraw (e.g. change filter to triple size and then back to HQ 3x).

Visible in other games as well, this is just an easy one to reproduce.

1 Attachments

Discussion

  • Sergio Baldoví

    Sergio Baldoví - 2018-12-29

    Fix attached. Original code (hiend3d) use these guards:

        if (j>0)      prevline = -spL; else prevline = 0;
        if (j<Yres-1) nextline =  spL; else nextline = 0;
    

    but Fuse's implementation removed them for hq2x. I guess because we usually scale rectangles intead of full frames.

    hq3x keeps one guard but I think it isn't needed as rgb_image at gtkdisplay states:

    "slightly bigger than the real screen to handle the smoothing filters which read around each pixel"

     
  • Sergio Baldoví

    Sergio Baldoví - 2018-12-30
    • assigned_to: Sergio Baldoví
    • Group: future --> NextRelease
     
  • Philip Kendall

    Philip Kendall - 2018-12-31

    Looks good to me.

     
  • Sergio Baldoví

    Sergio Baldoví - 2019-01-01
    • status: open --> pending-fixed
     
  • Sergio Baldoví

    Sergio Baldoví - 2019-01-01

    Thanks. Committed in [0eb11e].

     

    Related

    Commit: [0eb11e]

  • Sergio Baldoví

    Sergio Baldoví - 2021-02-06
    • status: pending-fixed --> closed-fixed
     

Log in to post a comment.

MongoDB Logo MongoDB