Conditionally make MPakArchive methods const based on Ogre version
With commit cbb02b the build fails with Ogre 1.9. Maybe another OGRE_VERSION conditional would work here? From the docs it seems that these five functions (exists, find, getModifiedTime, list, listFileInfo) were made const in Ogre 1.10. The 1.9 docs have these five functions being non-const and the 1.10 docs have them as const.
Make some methods const so they aren't pure virtual
Make some methods const so they aren't pure virtual
Fix mismatching allocation and deallocation: buffer
Fix filehandle leak found by Cppcheck.
Fix resource leak found by Cppcheck.
Fix mismatching allocation and deallocation: buffer
Fix filehandle leak found by Cppcheck.
Fix invalid new-expression of abstract class type.
Merged, thanks.
Fix invalid new-expression of abstract class type.
error compiling (sound related?)
I think this issue is long sinced fixed, please comment if you still have it.
mp3stream.cpp:77: error: ‘SHRT_MAX’ was not declared in this
This was fixed in commit d344e71b587aaf56e5899a45b84ed2667a88097f
objectsystem.cpp:29:51: error: ‘ObjectSystem* Ogre::Singleton<ObjectSystem>::ms_Singleton’ is not a static data member of ‘class Ogre::Singleton<ObjectSystem>’
I've applied the updated patch and pushed it to git master. I've taken the liberty of linking to this bug in the commit message. I see, thanks for the info about the authorship. It was a bit confusing as I was expecting most people would use their usual name and email in commit logs as I do. Sorry for assuming that. In future, please use git format-patch @{u} to generate patches as that makes it easier to apply them with git am. Also, if you prefer to use git rather than patches, SourceForge supports...
Fix ms_Singleton is not a static member of Singleton<>.
I made a branch named singleton in my local copy of the repository on sourceforge and Git is set up on my computer to use my GitHub ID and email. The patches ware made with git show > singleton.patch after commiting the change to my singleton branch with git commit for the first patch and git commit --amend for v2 and v3 patches. v3: moved conditional to include/ogreapp.h The Ogre version I'm using is 1.9. Funguloids builds with this patch and a few other changes.
The approach seems reasonable, but I would prefer to not duplicate the conditional in multiple files, perhaps put it in include/ogreapp.h instead. OTOH, I noticed that git master requires Ogre 1.9 already so I'm surprised it builds at all with 1.8 even though it doesn't have your patch. The patch does not include proper author information and I'd really like to know where it came from.
How about this patch? I added a check against OGRE_VERSION to define msSingleton to the older ms_Singleton if version < 1.8.
Hmm, the patch means that funguloids will not be buildable with Ogre 1.7 any more. I'd prefer if it could build with both Ogre 1.8 and 1.7 if possible. PS: where did you get the patch from? It looks like it comes from github?
objectsystem.cpp:29:51: error: ‘ObjectSystem* Ogre::Singleton<ObjectSystem>::ms_Singleton’ is not a static data member of ‘class Ogre::Singleton<ObjectSystem>’
Port funguloids to OGRE 1.9
Please create an AppData file for Funguloids
Fixed in git, thanks.
Ticket moved from /p/funguloids/support-requests/2/
Add AppData file.
Fix FTBFS with Ogre 1.6
Fixes crash due to Ogre update
Fix FTBFS with g++ 4.6
Allow building and working with newer Ogre
Fix for compiling with g++ 4.3
Make the Ogre Cg plugin optional since it is no...
Tell git to ignore some files
Please consider improving and installing this AppData file we wrote: https://raw...
Please create an AppData file for Funguloids