From: Bill R. <air...@gm...> - 2011-02-20 12:47:15
|
Hi there I was looking for a problem (which turned out to be in my own code not setting blend up correctly), but I found this along the way, which I think should be changed as the patch below. I might be wrong though. Thanks Bill Index: src/FTFont/FTTextureFont.cpp =================================================================== --- src/FTFont/FTTextureFont.cpp (revision 1261) +++ src/FTFont/FTTextureFont.cpp (working copy) @@ -243,7 +243,7 @@ glPushAttrib(GL_ENABLE_BIT | GL_COLOR_BUFFER_BIT | GL_TEXTURE_ENV_MODE); glEnable(GL_TEXTURE_2D); - glTexEnvf(GL_TEXTURE_ENV, GL_TEXTURE_ENV_MODE, GL_MODULATE); + glTexEnvi(GL_TEXTURE_ENV, GL_TEXTURE_ENV_MODE, GL_MODULATE); FTTextureGlyphImpl::ResetActiveTexture(); |
From: Bill R. <air...@gm...> - 2011-02-20 12:54:05
|
On 20 February 2011 12:47, Bill Robinson <air...@gm...> wrote: > Hi there > > I was looking for a problem (which turned out to be in my own code not > setting blend up correctly), but I found this along the way, which I > think should be changed as the patch below. I might be wrong though. > > Thanks > > Bill > PS. Also, there seems to be the same call in FTBufferFont. > > > Index: src/FTFont/FTTextureFont.cpp > =================================================================== > --- src/FTFont/FTTextureFont.cpp (revision 1261) > +++ src/FTFont/FTTextureFont.cpp (working copy) > @@ -243,7 +243,7 @@ > glPushAttrib(GL_ENABLE_BIT | GL_COLOR_BUFFER_BIT | GL_TEXTURE_ENV_MODE); > > glEnable(GL_TEXTURE_2D); > - glTexEnvf(GL_TEXTURE_ENV, GL_TEXTURE_ENV_MODE, GL_MODULATE); > + glTexEnvi(GL_TEXTURE_ENV, GL_TEXTURE_ENV_MODE, GL_MODULATE); > > FTTextureGlyphImpl::ResetActiveTexture(); > |
From: Dan H. <dh...@di...> - 2011-02-22 17:49:43
|
On Feb 20, 2011, at 4:54 AM, Bill Robinson wrote: > On 20 February 2011 12:47, Bill Robinson <air...@gm...> wrote: >> Hi there >> >> I was looking for a problem (which turned out to be in my own code not >> setting blend up correctly), but I found this along the way, which I >> think should be changed as the patch below. I might be wrong though. >> >> Thanks >> >> Bill >> > > > PS. Also, there seems to be the same call in FTBufferFont. I concur. Seems like a good fix, you should commit. Thanks Dan --- Dan Herman DigitalFish Animation Technologies http://www.digitalfish.com >> Index: src/FTFont/FTTextureFont.cpp >> =================================================================== >> --- src/FTFont/FTTextureFont.cpp (revision 1261) >> +++ src/FTFont/FTTextureFont.cpp (working copy) >> @@ -243,7 +243,7 @@ >> glPushAttrib(GL_ENABLE_BIT | GL_COLOR_BUFFER_BIT | GL_TEXTURE_ENV_MODE); >> >> glEnable(GL_TEXTURE_2D); >> - glTexEnvf(GL_TEXTURE_ENV, GL_TEXTURE_ENV_MODE, GL_MODULATE); >> + glTexEnvi(GL_TEXTURE_ENV, GL_TEXTURE_ENV_MODE, GL_MODULATE); >> >> FTTextureGlyphImpl::ResetActiveTexture(); >> > > ------------------------------------------------------------------------------ > The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: > Pinpoint memory and threading errors before they happen. > Find and fix more than 250 security defects in the development cycle. > Locate bottlenecks in serial and parallel code that limit performance. > http://p.sf.net/sfu/intel-dev2devfeb > _______________________________________________ > Ftgl-devel mailing list > Ftg...@li... > https://lists.sourceforge.net/lists/listinfo/ftgl-devel |
From: Bill R. <air...@gm...> - 2011-02-22 21:22:42
|
On 22 February 2011 17:18, Dan Herman <dh...@di...> wrote: > > On Feb 20, 2011, at 4:54 AM, Bill Robinson wrote: > > > On 20 February 2011 12:47, Bill Robinson <air...@gm...> wrote: > >> Hi there > >> > >> I was looking for a problem (which turned out to be in my own code not > >> setting blend up correctly), but I found this along the way, which I > >> think should be changed as the patch below. I might be wrong though. > >> > >> Thanks > >> > >> Bill > >> > > > > > > PS. Also, there seems to be the same call in FTBufferFont. > > > I concur. Seems like a good fix, you should commit. > > Thanks > Dan > I don't have permissions to commit directly to the ftgl sf repository. Index: src/FTFont/FTTextureFont.cpp =================================================================== --- src/FTFont/FTTextureFont.cpp (revision 1261) +++ src/FTFont/FTTextureFont.cpp (working copy) @@ -243,7 +243,7 @@ glPushAttrib(GL_ENABLE_BIT | GL_COLOR_BUFFER_BIT | GL_TEXTURE_ENV_MODE); glEnable(GL_TEXTURE_2D); - glTexEnvf(GL_TEXTURE_ENV, GL_TEXTURE_ENV_MODE, GL_MODULATE); + glTexEnvi(GL_TEXTURE_ENV, GL_TEXTURE_ENV_MODE, GL_MODULATE); FTTextureGlyphImpl::ResetActiveTexture(); Index: src/FTFont/FTBufferFont.cpp =================================================================== --- src/FTFont/FTBufferFont.cpp (revision 1261) +++ src/FTFont/FTBufferFont.cpp (working copy) @@ -237,7 +237,7 @@ glPushClientAttrib(GL_CLIENT_PIXEL_STORE_BIT); glEnable(GL_TEXTURE_2D); - glTexEnvf(GL_TEXTURE_ENV, GL_TEXTURE_ENV_MODE, GL_MODULATE); + glTexEnvi(GL_TEXTURE_ENV, GL_TEXTURE_ENV_MODE, GL_MODULATE); // Search whether the string is already in a texture we uploaded for(int n = 0; n < BUFFER_CACHE_SIZE; n++) |
From: Dan H. <dh...@di...> - 2011-02-22 22:29:10
|
On Feb 22, 2011, at 1:21 PM, Bill Robinson wrote: > On 22 February 2011 17:18, Dan Herman <dh...@di...> wrote: >> >> On Feb 20, 2011, at 4:54 AM, Bill Robinson wrote: >> >>> On 20 February 2011 12:47, Bill Robinson <air...@gm...> wrote: >>>> Hi there >>>> >>>> I was looking for a problem (which turned out to be in my own code not >>>> setting blend up correctly), but I found this along the way, which I >>>> think should be changed as the patch below. I might be wrong though. >>>> >>>> Thanks >>>> >>>> Bill >>>> >>> >>> >>> PS. Also, there seems to be the same call in FTBufferFont. >> >> >> I concur. Seems like a good fix, you should commit. >> >> Thanks >> Dan >> > > I don't have permissions to commit directly to the ftgl sf repository. And I thought I had permissions but it turns out I don't. Just mailed Henry but his sourceforge email bounced. Someone else? Dan > Index: src/FTFont/FTTextureFont.cpp > =================================================================== > --- src/FTFont/FTTextureFont.cpp (revision 1261) > +++ src/FTFont/FTTextureFont.cpp (working copy) > @@ -243,7 +243,7 @@ > glPushAttrib(GL_ENABLE_BIT | GL_COLOR_BUFFER_BIT | GL_TEXTURE_ENV_MODE); > > glEnable(GL_TEXTURE_2D); > - glTexEnvf(GL_TEXTURE_ENV, GL_TEXTURE_ENV_MODE, GL_MODULATE); > + glTexEnvi(GL_TEXTURE_ENV, GL_TEXTURE_ENV_MODE, GL_MODULATE); > > FTTextureGlyphImpl::ResetActiveTexture(); > > Index: src/FTFont/FTBufferFont.cpp > =================================================================== > --- src/FTFont/FTBufferFont.cpp (revision 1261) > +++ src/FTFont/FTBufferFont.cpp (working copy) > @@ -237,7 +237,7 @@ > glPushClientAttrib(GL_CLIENT_PIXEL_STORE_BIT); > > glEnable(GL_TEXTURE_2D); > - glTexEnvf(GL_TEXTURE_ENV, GL_TEXTURE_ENV_MODE, GL_MODULATE); > + glTexEnvi(GL_TEXTURE_ENV, GL_TEXTURE_ENV_MODE, GL_MODULATE); > > // Search whether the string is already in a texture we uploaded > for(int n = 0; n < BUFFER_CACHE_SIZE; n++) |