SF.net SVN: frontierkernel: [1299] Frontier/branches/Conversant/Common/source/langstartup.c

[<set...@us...>]

Revision: 1299
Author:   sethdill
Date:     2006-04-18 13:00:27 -0700 (Tue, 18 Apr 2006)
ViewCVS:  http://svn.sourceforge.net/frontierkernel/?rev=1299&view=rev

Log Message:
-----------
Added a big comment at langinit_charset_consttable() so it's clear why it's there and what it does.

Modified Paths:
--------------
    Frontier/branches/Conversant/Common/source/langstartup.c
Modified: Frontier/branches/Conversant/Common/source/langstartup.c
===================================================================
--- Frontier/branches/Conversant/Common/source/langstartup.c	2006-04-18 19:40:22 UTC (rev 1298)
+++ Frontier/branches/Conversant/Common/source/langstartup.c	2006-04-18 20:00:27 UTC (rev 1299)
@@ -590,6 +590,23 @@
 
 static boolean langinit_charset_consttable (void) {
 	
+	/*
+		First pass at a way to populate a table with many of
+		the known charsets. Key is the MIME charset name (the 
+		IANA-registered name), value is the platform-dependent 
+		value that identifies that character set. (Constants on
+		Mac, code page id numbers on Windows.)
+		
+		There may be a one-hit memory leak here, because nothing is done
+		to release the table... but maybe it can't be released, because
+		it needs to stick around?
+		
+		A better approach on both platforms would be some routine that
+		asks the OS for a list of the character sets it supports.
+		I couldn't find anything like that on the Mac, and on Windows
+		it requires COM which I couldn't get to work!
+	*/
+	
 	hdlhashtable hcharsetconsttable;
 	
 	if (!tablenewsystemtable (langtable, (ptrstring) "\x08" "charsets", &hcharsetconsttable))


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.