From: Ian S. A. R. <ia...@ae...> - 2010-04-29 16:07:00
|
On 29/04/10 03:59 PM, doug sanden wrote: > Something else that bugs MSVC - when your macro doesn't have the same > number of parameters as the thing that gets called in its place. I can > do variable parameters in msvc with (...) which includes 0 parameters. > If your compiler somehow takes something off the call parameter stack > for (aaa) that would cause trouble. > > display.h ~L454 > #if defined(_MSC_VER) > #define FW_GL_PUSH_MATRIX(...) glPushMatrix() <<<< I'm compiling with this > #define FW_GL_POP_MATRIX(...) glPopMatrix() > #endif > ... > #ifndef _MSC_VER > #define FW_GL_PUSH_MATRIX(aaa) glPushMatrix() <<<<< linux compiles with this > #define FW_GL_POP_MATRIX(aaa) glPopMatrix() > #endif > > the push and pop should not have parameters: > #define FW_GL_PUSH_MATRIX() glPushMatrix() > yeah that bugged me too. Actually, currently (on linux at any rate) there are warnings because those two defines are done twice (i believe the first ones at line 440 and 441 take precedence). I rolled the tarball as-is because things worked well as they were, but both of these should be fixed for 1.22.8.1 methinks? |