[Freevo-tracker] [ freevo-Bugs-1632721 ] Audio player shows wrong bitrate

[SourceForge.net <no...@so...>]

Bugs item #1632721, was opened at 2007-01-10 12:42
Message generated for change (Comment added) made by sf-robot
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=446895&aid=1632721&group_id=46652

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: skins
Group: kaa svn
>Status: Closed
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Frank Naude (naudefj)
Assigned to: Dirk Meyer (dischi)
Summary: Audio player shows wrong bitrate

Initial Comment:
Bitrate for this file is shown as 128000kb/s instead of 128kb/s:

$ ogginfo audio.ogg
...
Version: 0
Vendor: Xiph.Org libVorbis I 20020717 (1.0)
Channels: 2
Rate: 44100

Nominal bitrate: 128.000000 kb/s
Upper bitrate: 4294967.295000 kb/s
Lower bitrate: 4294967.295000 kb/s
...

----------------------------------------------------------------------

>Comment By: SourceForge Robot (sf-robot)
Date: 2007-02-26 19:20

Message:
Logged In: YES 
user_id=1312539
Originator: NO

This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).

----------------------------------------------------------------------

Comment By: Frank Naude (naudefj)
Date: 2007-02-11 22:21

Message:
Logged In: YES 
user_id=143611
Originator: YES

Message from fre...@li...:

> > The problem can easily be fixed with a simple patch like this:
> >
> > Index: kaa/metadata/src/audio/ogg.py
> > ===================================================================
> > --- kaa/metadata/src/audio/ogg.py       (revision 2455)
> > +++ kaa/metadata/src/audio/ogg.py       (working copy)
> > @@ -69,6 +69,7 @@
> >          self.version, self.channels, self.samplerate, bitrate_max, \
> >                        self.bitrate, bitrate_min, blocksize, \
> >                        framing = struct.unpack('<IBIiiiBB',info[:23])
> > +       self.bitrate = self.bitrate / 1000;
> >          # INFO Header, read Oggs and skip 10 bytes
> >          h = file.read(4+10+13)
> >          if h[:4] == 'OggS':
> >
> > However, this is not the best way of solving the problem. I would
really
> > appreciate if you can help with a proper fix.
>
> No, it is the proper way to fix this. In svn now.

Great. Thank you very much!

Best regards.

Frank

----------------------------------------------------------------------

Comment By: Duncan Webb (duncanwebb)
Date: 2007-01-14 05:29

Message:
Logged In: YES 
user_id=104395
Originator: NO

mp3 shows kb/s
ogginfo shows kb/s (as a float)

from oggenc man page:
-b n, --bitrate=n
 Sets  target  bitrate to n (in kb/s). The encoder will attempt to encode
at approximately this bitrate. By default, this remains a VBR encoding.
See the --managed option to force a  managed bitrate encoding at the
selected bitrate.

So I would suggest kb/s as a suitable value, may be as a float.



----------------------------------------------------------------------

Comment By: Frank Naude (naudefj)
Date: 2007-01-14 03:50

Message:
Logged In: YES 
user_id=143611
Originator: YES

Discussion from #freevo:

13:45:28 dischi  

naudefj: ok, the mp3 and ogg parser use a different base. Well, ok, at
least one of the two has to be changed.
I will wait for Tack would he thinks

----------------------------------------------------------------------

Comment By: Dirk Meyer (dischi)
Date: 2007-01-14 03:44

Message:
Logged In: YES 
user_id=33647
Originator: NO

What does mminfo show? 128000 is correct because the bitrate is bit/s. It
is the same for other parser (I just tested a mpg file). But the real
question here is if we should always use kbit/s or always bit/s?

----------------------------------------------------------------------

Comment By: Duncan Webb (duncanwebb)
Date: 2007-01-11 13:44

Message:
Logged In: YES 
user_id=104395
Originator: NO

More information

mminfo now shows bitrate: 128000 for ogg files and 128 for mp3 files.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=446895&aid=1632721&group_id=46652