[Freevo-tracker] [ freevo-Bugs-2985990 ] recordserver does not run VCR_POST_REC command

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 454-5900

Bugs item #2985990, was opened at 2010-04-12 18:08
Message generated for change (Comment added) made by izio
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=446895&aid=2985990&group_id=46652

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: helpers
Group: 1.9.x
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Fabrizio Ferraro (izio)
Assigned to: Nobody/Anonymous (nobody)
Summary: recordserver does not run VCR_POST_REC command

Initial Comment:
I tried to enable a post-recording command by setting:
VCR_POST_REC = '/home/izio/freevo_post %(self.prog.filename)s'
in local_conf.py.

The command is not executed, following is the relevant section from the recordserver log file:
2010-04-12 16:34:09,154 INFO     recordserver.py (1026): RECORD_STOP Mon Apr 12 15:10->16:15 (15:10)  www.rete4.com Wolff un poliziotto a Berlino
2010-04-12 16:34:09,156 INFO     recordserver.py (1381): post-processing started for Mon Apr 12 15:10->16:15 (15:10)  www.rete4.com Wolff un poliziotto a Berlino
2010-04-12 16:34:09,723 WARNING  videothumb.py (124): no imagefile found for "/data3/FREEVO/recordings/04-12_15:10_Wolff_un_poliziotto_a_Berlino_-_Immunita.ts"
2010-04-12 16:34:09,726 WARNING  recordserver.py (1043): event=OS_EVENT_POPEN2 arg=(<util.popen3.child_handler instance at 0x2cbd050>, '/home/izio/freevo_post %(self.prog.filename)s') not handled
2010-04-12 16:35:45,002 INFO     recordserver.py (970): found a program to clean: Mon Apr 12 15:10->16:15 (15:10)  www.rete4.com Wolff un poliziotto a Berlino

I tried to follow the execution path in the source code and it seems that the function popen3 defined in util.popen3.py will post the OS_EVENT_POPEN2 event instead of running the child processes, but there's no event handler for OS_EVENT_POPEN2 in the record server.

----------------------------------------------------------------------

Comment By: Fabrizio Ferraro (izio)
Date: 2010-05-16 21:04

Message:
Hi Duncan,
your proposed patch is of course better than mine.

I have been testing it for a couple of days and it works as expected, so
feel free to commit it.

Thanks a lot!

----------------------------------------------------------------------

Comment By: Duncan Webb (duncanwebb)
Date: 2010-05-09 16:09

Message:
May be this is a better patch
         if config.VCR_POST_REC:
-            util.popen3.Popen3(config.VCR_POST_REC)
+            cmd = config.VCR_POST_REC % self.prog.__dict__
+            util.popen3.Popen3(cmd)

It will allow any self.prog attribute to be used like:
VCR_POST_REC = 'abc %(filename)s %(title)s'

If you would like to test this and say if it works then I'll commit it.

Attributes include:
'scheduled': False
'ratings': {}
'previouslyRecorded': 0
'allowDuplicates': 1
'title': u'Shark'
'favorite': False
'isRecording': False
'pdc_start': 1273411200
'sub_title': ''
'overlap': 0
'filename': '/freevo/tv/recordings/20100509_1520_Shark.mpeg'
'stop': 1273413600
'channel_id': 'CNI0497'
'advisories': []
'onlyNew': 0
'rec_duration': 120
'date': ''
'tunerid': '0'
'start': 1273411200
'categories': ['Serie', 'Krimi/Thriller']
'desc': u'8 - In Flagranti (Anwalts-Serie, USA 2006)'

----------------------------------------------------------------------

Comment By: Fabrizio Ferraro (izio)
Date: 2010-04-29 23:01

Message:
Duncan,

thanks for submitting the patch.

I've attached a patch to add the recording filename to the VCR_POST_REC
command.
Now one could set:
VCR_POST_REC = `/path/to/my/post_proc_cmd %(filename)s'
in local_conf.py

----------------------------------------------------------------------

Comment By: Duncan Webb (duncanwebb)
Date: 2010-04-28 18:09

Message:
Hi Fabrizio,

I've submitted the patch as your possible the only user of this code it
won't affect anyone else.

Your more than welcome to send in a patch a add the file name.

----------------------------------------------------------------------

Comment By: Fabrizio Ferraro (izio)
Date: 2010-04-28 10:52

Message:
Seems like I spoke too early :(

I made my tests with a dummy post-process script which simply wrote a line
in a log file, but after I exchanged it with the real thing, which uses
mencoder to remux the recording file, I found some zombie process left.
Also, sometimes mencoder hangs at the end of the encoding, seems like
waiting for something.
I suspect it's a stdin/stdout related issue.

Running the script outside of freevo works correctly.

I need to further investigate the issue, so hold on by now, I'll let you
know.

----------------------------------------------------------------------

Comment By: Fabrizio Ferraro (izio)
Date: 2010-04-27 21:34

Message:
Many thanks for the patch, Duncan.

I have tested it by scheduling some recordings this afternoon and it seems
to work pretty well. The command is executed and the log file doesn't show
anything strange.
So, as far as I'm concerned, you can submit the patch to the svn. I'm
wondering why the code was removed.

There is one last thing I'm still missing: I'd like to have the
recordserver to append the recording filename to the command, so it will be
much easier to run some post-process on the file.
If you think it would be useful, I'll send a patch.

Cheers,
izio

----------------------------------------------------------------------

Comment By: Duncan Webb (duncanwebb)
Date: 2010-04-26 17:47

Message:
Hi

The code for the POPEN events was removed a long time ago (before 1.8.0)
so it is not widely used.

Anyway, the attached patch will put the code back in again. If you can
test it and report if it works then it should be submitted into svn.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=446895&aid=2985990&group_id=46652