Menu
▾
▴
[Freevo-tracker] [ freevo-Bugs-2941814 ] "Recursive (random) play all items" and symlinks
|
From: SourceForge.net <no...@so...> - 2010-02-26 02:20:19
|
Bugs item #2941814, was opened at 2010-01-28 20:27 Message generated for change (Comment added) made by sf-robot You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=446895&aid=2941814&group_id=46652 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: other Group: 1.9.x >Status: Closed Resolution: Accepted Priority: 5 Private: No Submitted By: George Kibardin (george_kibardin) Assigned to: Nobody/Anonymous (nobody) Summary: "Recursive (random) play all items" and symlinks Initial Comment: When directory where you want to "Recursive (random) play all items" contains symlinks to directories they are not taken into account. And when all items in a directory are symlinks we even get excpetion trying to do this. The patch that fixes this is attached. ---------------------------------------------------------------------- >Comment By: SourceForge Robot (sf-robot) Date: 2010-02-26 02:20 Message: This Tracker item was closed automatically by the system. It was previously set to a Pending status, and the original submitter did not respond within 14 days (the time period specified by the administrator of this Tracker). ---------------------------------------------------------------------- Comment By: Duncan Webb (duncanwebb) Date: 2010-02-11 16:21 Message: Many thanks George, Your patch has been applied to svn at rev 11657. Slight change is that FOLLOW_SYMLINKS is now SYS_FOLLOW_SYMLINKS ---------------------------------------------------------------------- Comment By: George Kibardin (george_kibardin) Date: 2010-02-09 08:12 Message: Sorry, forgot to mention, I've tested the patch with symlinks (and with recursive symlinks) and it worked fine. ---------------------------------------------------------------------- Comment By: George Kibardin (george_kibardin) Date: 2010-02-03 20:00 Message: Hi Duncan, Here is new patch, now symlinks recursion is driven by config parameter which is False by default. Is it possible to convert this defect to the feature request or I must explicitly create one? Best, George ---------------------------------------------------------------------- Comment By: Duncan Webb (duncanwebb) Date: 2010-02-01 16:14 Message: Hi George, Sorry I still don't consider this a bug, but a feature request. >From the Python manuals: Note: On systems that support symbolic links, links to subdirectories appear in dirnames lists, but walk() will not visit them (infinite loops are hard to avoid when following symbolic links). To visit linked directories, you can identify them with os.path.islink(path), and invoke walk(path) on each directly. So what I propose is to allow to follow symlinks but this feature has to be explicitly enabled. The patch attached should do this. Will you please test this patch. Thanks ---------------------------------------------------------------------- Comment By: George Kibardin (george_kibardin) Date: 2010-01-30 19:24 Message: How could I forget about this problem!! Anyway, symlinks are too convenient so, now it is recursion proof! Check out the new patch. ---------------------------------------------------------------------- Comment By: Duncan Webb (duncanwebb) Date: 2010-01-29 16:47 Message: Hi George, It is normal practice to ignore symlinks as they can lead to endless loops. Sorry I don't consider this a bug. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=446895&aid=2941814&group_id=46652 |