[Freevo-tracker] [ freevo-Bugs-2925568 ] freevo crashes on certain id3 tags

[SourceForge.net <no...@so...>]

Bugs item #2925568, was opened at 2010-01-04 12:46
Message generated for change (Settings changed) made by duncanwebb
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=446895&aid=2925568&group_id=46652

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: core
Group: 1.9.x
>Status: Pending
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Alan (alancio)
Assigned to: Nobody/Anonymous (nobody)
Summary: freevo crashes on certain id3 tags

Initial Comment:
freevo crashes whenever I browse a directory containing an mp3 file which has certain id3 tag.
I don't know exactly which tag causes freevo to crash, but I suspect an embedded jpeg image.
This is the list of tags in the file:

bash$ id3info 06\ -\ gonzales\ -\ the\ tourist.mp3

*** Tag information for 06 - gonzales - the tourist.mp3
=== TPE2 (Band/orchestra/accompaniment): gonzales
=== TIT2 (Title/songname/content description): the tourist
=== TALB (Album/Movie/Show title): realish mix 2007 / side two
=== TPUB (Publisher): sunny side
=== TCON (Content type): instrumental
=== TYER (Year): 2007
=== TRCK (Track number/Position in set): 06
=== TPOS (Part of a set): 1/1
=== TPE1 (Lead performer(s)/Soloist(s)): gonzales
=== TCOM (Composer): gonzales
=== WCOM (Commercial information): http://www.amazon.com/gp/redirect.html%3FASIN=B000NIIUM4%26tag=softpointer-20%26lcode=xm2%26cID=2025%26ccmID=165953%26location=/o/ASIN/B000NIIUM4%253FSubscriptionId=0RXJS26C80QSDEB56CR2
=== TXXX (User defined text information): (COMMENT):  00000000 00000210 00000834 000000000072BEBC 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
=== TXXX (User defined text information): (replaygain_album_gain): -8.90 dB
=== TXXX (User defined text information): (replaygain_album_peak): 1.140749
=== TXXX (User defined text information): (replaygain_track_gain): -3.34 dB
=== TXXX (User defined text information): (replaygain_track_peak): 1.015381
=== COMM (Comments): ()[eng]: realish mix 2007 - realish.com
=== APIC (Attached picture): (mage/jpg)[, 105]: , 33445 bytes
=== COMM (Comments): (ID3v1 Comment)[XXX]:  00000000 00000210 00000834
*** mp3 info
MPEG1/layer III
Bitrate: 320KBps
Frequency: 44KHz

----------------------------------------------------------------------

>Comment By: Duncan Webb (duncanwebb)
Date: 2010-01-29 17:44

Message:
Good to know. I think that the embedded image is corrupt, looks like it
using mminfo and eyeD3.

----------------------------------------------------------------------

Comment By: Alan (alancio)
Date: 2010-01-28 13:22

Message:
Hi Duncan,

This change appears to fix the crash.  I can't see the album image of the
song, but at least freevo doesn't crash anymore, thanks.

----------------------------------------------------------------------

Comment By: Duncan Webb (duncanwebb)
Date: 2010-01-28 12:51

Message:
Thanks ALan,

Easy to fix when the problem can be reproduced. It is a type in the debug
statement that caused this problem.

Fixed in r11649.

Index: src/util/fileops.py
===================================================================
--- src/util/fileops.py (revision 11646)
+++ src/util/fileops.py (working copy)
@@ -523,7 +523,7 @@
         try:
             image = kaa.imlib2.open_from_memory(thumbnail)
         except Exception, why:
-            _debug_('invalid thumbnail %r: %s', (filename, why), DINFO)
+            _debug_('invalid thumbnail %r: %s' % (filename, why), DINFO)
 
     if not image:
         if __freevo_app__ == 'main':


----------------------------------------------------------------------

Comment By: Alan (alancio)
Date: 2010-01-17 11:36

Message:
The proposed solution doesn't fix the problem.
I can't attach the mp3 file because sourceforge has a severe attachment
limitation.
Please download the file from this link:
http://rapidshare.com/files/336632003/06_-_gonzales_-_the_tourist.mp3.html

Alternatively, you can find a torrent containing this file by using a web
search engine, use the term: "Realish Mix 2007".
The song is song number 6 of side two.

----------------------------------------------------------------------

Comment By: Duncan Webb (duncanwebb)
Date: 2010-01-07 20:05

Message:
>  File "/usr/lib/python2.6/site-packages/freevo/util/fileops.py", line
528, in create_thumbnail
>    _debug_('invalid thumbnail %r: %s', (filename, why), DINFO)

A simple fix is to change line 528 in util/fileops.py replacing the %s by
a %r like:
    _debug_('invalid thumbnail %r: %r', (filename, why), DINFO)

I can't say what is in the variable why but it should be clear after the
change. If you can do the change and report what it now does it may be
possible to fix the problem. If it still fails you can attach the .mp3 file
so I can test.

Thanks

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=446895&aid=2925568&group_id=46652