Menu
▾
▴
[Freevo-devel] [ freevo-Bugs-1563153 ] freevo-1.5.4 with LCDproc-0.5 & later
|
From: SourceForge.net <no...@so...> - 2006-09-30 13:57:38
|
Bugs item #1563153, was opened at 2006-09-21 22:54 Message generated for change (Settings changed) made by duncanwebb You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=446895&aid=1563153&group_id=46652 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: plugins Group: 1.5.4 >Status: Pending Resolution: None Priority: 5 Submitted By: Lucian Muresan (lucianm) Assigned to: Nobody/Anonymous (nobody) Summary: freevo-1.5.4 with LCDproc-0.5 & later Initial Comment: Hi, the old patch Gustavo Barbieri made in february 2005 to make lcd.py (freevo-1.5.4) work with LCDproc-0.5 still works for me in the last release, and wasn't applied. Please someone running Freevo-1.5.(4) confirm if it still works with the outdated LCDproc-0.4.x. Note that my version of the patch changes the screen size from 20 to 18 chars per line to match my VFD size, you might want to revert that manually in the patch itself before applying it. If this gets commited to the 1.5.x tree, I think it's better if both screen sizes 20x4 and 18x4 are inlcuded (they actually use identical layout, so maybe some python guru knows how to do this more elegant than copying the layout one more time. Lucian ---------------------------------------------------------------------- Comment By: Michael Ruelle (mikeruelle) Date: 2006-09-29 15:32 Message: Logged In: YES user_id=849534 maybe you can run a regular expression over the string variables after detection? maybe start off with the four slashes and then run a regex to convert to two if we run greater than 0.4? ---------------------------------------------------------------------- Comment By: Duncan Webb (duncanwebb) Date: 2006-09-29 12:28 Message: Logged In: YES user_id=104395 Hi Lucian, I done a change for this, maybe this will work. See r8256. I've moved the animations characters into the class and checked the version to select a particular set. Would you please check this change, Thanks. ---------------------------------------------------------------------- Comment By: Lucian Muresan (lucianm) Date: 2006-09-29 09:14 Message: Logged In: YES user_id=566541 As I said, I'm not y python programmer, but as far as I can understand, the lcdproc version is checked later, maybe too late. Maybe the whole plugin has to be rewritten to achieve this. ---------------------------------------------------------------------- Comment By: Duncan Webb (duncanwebb) Date: 2006-09-29 08:30 Message: Logged In: YES user_id=104395 One last thought on this, would it be possible to check the lcdproc version and use '\\' for >=0.5.0 and '\\\\' for <0.5.0? ---------------------------------------------------------------------- Comment By: Lucian Muresan (lucianm) Date: 2006-09-28 08:09 Message: Logged In: YES user_id=566541 With chr(92) instead of '\\\\' it displays 92 in lcdproc-0.5, and seems to work in lcdproc-0.4.x. >From what I could see having a quick look at lcdproc's source code, I think they are treating '\\' differently in the new parser. If nobody can fix this at python side in freevo, ss there are those other incompatibilities betweehn lcdproc versions anyway, I wouldn't really regard this as a bug worth filing upstream to lcdproc, but rather decide leave it working for lcdproc-0.5 at this point. A note could be made to tell the user that if he's seeing a double '\\' during animation, then he's using a 0.4.x lcdproc and he can fix the behavioer by editing /usr/lib/python.2.4/site-packages/freevo/plugins/lcd.py at line 78 and change '\\\\' into '\\'. This is not really completely dropping support for lcdproc-0.4.x, (like suggested with other bugs related to mplayer or xine) but rather encouraging people to upgrade to 0.5 which has been released for 6 months now. Maybe not all distributions have it yet, at least for Gentoo I could provide an ebuild. ---------------------------------------------------------------------- Comment By: Duncan Webb (duncanwebb) Date: 2006-09-27 11:18 Message: Logged In: YES user_id=104395 The patch freevo-1.5.4_lcdproc_inc_20060927.diff has been applied to r8246 ---------------------------------------------------------------------- Comment By: Duncan Webb (duncanwebb) Date: 2006-09-27 11:11 Message: Logged In: YES user_id=104395 What happens if you used chr(92) instread of '\\\\' ---------------------------------------------------------------------- Comment By: Lucian Muresan (lucianm) Date: 2006-09-27 01:38 Message: Logged In: YES user_id=566541 The '\\\\' issue in animation_audioplayer_chars is still unsolved. '\\\\' works in lcdproc-0.5, but doubles the '\' symbol on lcdproc-0.4.5. Just '\\' displays nothing in both versions. "\\" works in lcdproc-0.4.5 but keeps the previously displayed charater in lcdproc-0.5. I'm no python programmer, if someone could patch this animation_audioplayer_chars to be a variable initialized after the client talks to the lcdproc server... But I don't think it's even possible, as it's used in the layouts...:-( Strange... ---------------------------------------------------------------------- Comment By: Lucian Muresan (lucianm) Date: 2006-09-27 01:10 Message: Logged In: YES user_id=566541 Thank you Robert for hinting on these problems. My display is only supported by lcdproc-0.5 because only that's the version I wrote the driver for, so I never had a look on how Freevo looks on lcdproc-0.4.x until tonight, on the curses display. Well, I did those ' -> \" modifications, including one at line 831, but slightly different than yours and tried with both versions, with 0.5 on my real display, and 0.4.5 on ncurses, and it works. Duncan, please apply the attached patch (incremental to current CVS) and let people check if it really works on their displays. ---------------------------------------------------------------------- Comment By: Lucian Muresan (lucianm) Date: 2006-09-27 01:10 Message: Logged In: YES user_id=566541 Thank you Robert for hinting on these problems. My display is only supported by lcdproc-0.5 because only that's the version I wrote the driver for, so I never had a look on how Freevo looks on lcdproc-0.4.x until tonight, on the curses display. Well, I did those ' -> \" modifications, including one at line 831, but slightly different than yours and tried with both versions, with 0.5 on my real display, and 0.4.5 on ncurses, and it works. Duncan, please apply the attached patch (incremental to current CVS) and let people check if it really works on their displays. ---------------------------------------------------------------------- Comment By: Robert Buchholz (goodpoint) Date: 2006-09-23 23:19 Message: Logged In: YES user_id=1550003 While we're at it, there's two other lcd.py issues: At least with me, in "animation_audioplayer_chars" (line 78) the character '\\' has to be '\\\\', but this could also be caused by the ' -> \" modifications and this definately worked in 0.4.5 before. Also, in line 831 it says: percentage = float( player.elapsed ) / player.info.video[0].length this always fails for me. Changing to: percentage = float( player.elapsed ) / player.info["length"] works for the hbar and percantage counter. ---------------------------------------------------------------------- Comment By: Robert Buchholz (goodpoint) Date: 2006-09-23 21:49 Message: Logged In: YES user_id=1550003 As said, I did look into this and found that in lcd.py, all strings sent to LCDd are enclosed in simple quotes. But LCDd expects strings with double quotes or simple "words" (no spaces) without any quotes. So when sending '[' for instance, LCDd decides that this is a single word with three characters. Solution that worked with me: Convert all ' in the menu structure to \" OR exchange " and ' in the python strings. Unfortunately, I don't know if this is backwards-compatible to 0.4.5 :-/ ---------------------------------------------------------------------- Comment By: Robert Buchholz (goodpoint) Date: 2006-09-23 14:35 Message: Logged In: YES user_id=1550003 I tried the patch with lcdproc-0.5.0 and I found that when playing some media (video/music), the display has some glitches: the rotating dash (|, /, -, \, ...) has a quotation marks ' around it, so basically it displays '/' '-' '\' Also, the progress bar does not work and it does not display the runtime, which it did before, but maybe some of these problems are because I have a 40x2 LCD. Anyone else experiencing this? I'll have a closer look at this problem later myself. Robert ---------------------------------------------------------------------- Comment By: Duncan Webb (duncanwebb) Date: 2006-09-22 07:37 Message: Logged In: YES user_id=104395 I've applied the patch and removed any trailing white space. Somebody with a LCD device needs to check this, report back and close the bug ---------------------------------------------------------------------- Comment By: Duncan Webb (duncanwebb) Date: 2006-09-22 07:37 Message: Logged In: YES user_id=104395 Patch applied to branches/rel-1-5/freevo at: svn://svn.freevo.org/freevo/branches/rel-1-5/freevo ---------------------------------------------------------------------- Comment By: Lucian Muresan (lucianm) Date: 2006-09-22 07:05 Message: Logged In: YES user_id=566541 Thanx for your feedback, Robert. Yes, its is working with LCDproc-0.5, I couldn't use it other way myself ---------------------------------------------------------------------- Comment By: Lucian Muresan (lucianm) Date: 2006-09-22 06:59 Message: Logged In: YES user_id=566541 Thanx for your feedback, Robert. Yes, its is working with LCDproc-0.5, I couldn't use it other way myself ---------------------------------------------------------------------- Comment By: Robert Buchholz (goodpoint) Date: 2006-09-22 02:25 Message: Logged In: YES user_id=1550003 Hey, I applied the patch to my freevo-1.5.4 and it still works with lcdproc-0.4.5. I guess this should definately be included in a maintenance release of the old branch. Didn't test if it works with lcdproc-0.5 yet, sorry. Robert ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=446895&aid=1563153&group_id=46652 |