[Freeorion-programmers] [ freeorion-Bugs-1635626 ] command line parameter crashes client

[SourceForge.net <no...@so...>]

Bugs item #1635626, was opened at 2007-01-15 08:23
Message generated for change (Comment added) made by guardian24
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=544942&aid=1635626&group_id=75752

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Client
Group: Latest Subversion
Status: Open
Resolution: None
Priority: 8
Private: No
Submitted By: Geoff Topping (geoffthemedio)
Assigned to: Nobody/Anonymous (nobody)
Summary: command line parameter crashes client

Initial Comment:
>From command prompt window in WinXP, starting FO with the command

freeorion --fullscreen

crashes the client.  Part of the stack trace:

 	msvcr80.dll!strlen(unsigned char * buf=0x0012f7b0)  Line 81	Asm
 	msvcp80.dll!std::basic_string<char,std::char_traits<char>,std::allocator<char> >::assign(const char * _Ptr=0x00000000)  Line 1042 + 0xb bytes	C++
 	msvcp80.dll!std::basic_string<char,std::char_traits<char>,std::allocator<char> >::basic_string<char,std::char_traits<char>,std::allocator<char> >(const char * _Ptr=0x00000000)  Line 644	C++
>	freeorion.exe!OptionsDB::SetFromCommandLine(int argc=2, char * * argv=0x015bb318)  Line 310	C++
 	freeorion.exe!SDL_main(int argc=2, char * * argv=0x015bb318)  Line 34	C++


----------------------------------------------------------------------

Comment By: guardian24 (guardian24)
Date: 2007-02-23 10:48

Message:
Logged In: YES 
user_id=1536944
Originator: NO

Well, i guess it is this:
Line 26 from chmain.cpp:
GetOptionsDB().Add('f', "fullscreen", "OPTIONS_DB_FULLSCREEN", false);
It COULD be:
GetOptionsDB().AddFlag('f', "fullscreen", "OPTIONS_DB_FULLSCREEN");

Of course, this would mean a different behaviour, as the game would 
start in windowed mode, when launched without command-line options?!
(I have lost my will to compile FO on Windows. :(( )
On the other hand, it could be a problem with the two Add-s, which are
both
template functions.
Maybe line 26 in chmain.cpp is missing a template parameter, like:
GetOptionsDB().Add<bool>('f', "fullscreen", "OPTIONS_DB_FULLSCREEN",
false);
(Or bool does need it? I have no clue. :o )

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2007-02-02 14:07

Message:
Logged In: NO 

linux:
./freeorion -f
main() caught exception(std::exception): basic_string::_S_construct NULL
not validUsage:
--GameSetup.galaxy-age
     The shape of the galaxy to be generated. | Default: AGE_MATURE

--GameSetup.galaxy-shape
     The shape of the galaxy to be generated. | Default: SPIRAL_3
etc

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=544942&aid=1635626&group_id=75752