#308 Heap buffer overflow in PluginTIFF.cpp:1638

[freeKim]

Heap buffer overflow in PluginTIFF.cpp:1638

Summary:

There is a heap buffer overflow in PluginTIFF.cpp(line 1638) while loading image with FreeImage_Load function。

Version Affected: 3.19.0 (r1828)

ASAN Details

==3314==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x602000000156 at pc 0x561c7b28d3df bp 0x7ffe77d9ce40 sp 0x7ffe77d9ce30
READ of size 1 at 0x602000000156 thread T0
    #0 0x561c7b28d3de in Load Source/FreeImage/PluginTIFF.cpp:1638
    #1 0x561c7b17f47b in FreeImage_LoadFromHandle Source/FreeImage/Plugin.cpp:388
    #2 0x561c7b17f47b in FreeImage_LoadFromHandle Source/FreeImage/Plugin.cpp:380
    #3 0x561c7b17f952 in FreeImage_Load Source/FreeImage/Plugin.cpp:408
    #4 0x561c7b13a12b in main /home/lab4/src/freeimage-svn/FreeImage/trunk/load-test.c:16
    #5 0x7fe6bab2cb6a in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x26b6a)
    #6 0x561c7b14af69 in _start (/home/lab4/src/freeimage-svn/FreeImage/trunk/load-test+0x149f69)

0x602000000156 is located 0 bytes to the right of 6-byte region [0x602000000150,0x602000000156)
allocated by thread T0 here:
    #0 0x7fe6bb147448 in malloc (/lib/x86_64-linux-gnu/libasan.so.5+0x10c448)
    #1 0x561c7b28c961 in Load Source/FreeImage/PluginTIFF.cpp:1618
    #2 0x561c7b17f47b in FreeImage_LoadFromHandle Source/FreeImage/Plugin.cpp:388
    #3 0x561c7b17f47b in FreeImage_LoadFromHandle Source/FreeImage/Plugin.cpp:380
    #4 0x561c7b17f952 in FreeImage_Load Source/FreeImage/Plugin.cpp:408
    #5 0x561c7b13a12b in main /home/lab4/src/freeimage-svn/FreeImage/trunk/load-test.c:16

SUMMARY: AddressSanitizer: heap-buffer-overflow Source/FreeImage/PluginTIFF.cpp:1638 in Load
Shadow bytes around the buggy address:
  0x0c047fff7fd0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c047fff7fe0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c047fff7ff0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c047fff8000: fa fa 00 00 fa fa fd fa fa fa 00 fa fa fa 01 fa
  0x0c047fff8010: fa fa fd fa fa fa fd fa fa fa 00 fa fa fa fd fa
=>0x0c047fff8020: fa fa 00 fa fa fa 00 fa fa fa[06]fa fa fa fa fa
  0x0c047fff8030: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c047fff8040: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c047fff8050: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c047fff8060: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c047fff8070: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07 
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
  Shadow gap:              cc
==3314==ABORTING
Aborted

Reproduce

To reproduce it ,compile FreeImage with ASAN. Then compile and execute the test file in the attachment as follows:

Clang++ -g -fsanitize=address load-test.c -lfreeimage -L. -lm -o load-test
./load-test oob_read_PluginTIFF_1638

Credit

ADLab of Venustech

[Hervé Drolon]

fixed with patch https://sourceforge.net/p/freeimage/patches/143/