RE: [Freeglut-developer] Re: Local functions in freeglut.

[Fay J. F C. AAC/W. <joh...@eg...>]

Richard,

	It has been a couple of weeks, so please refresh my memory about
your non-controversial comment in "og_internal.h".  I'm missing something.

	I took a look at your suggestion (translated into freeglut-speak) of
moving "fgCreateMenu" from "freeglut_structure.c" into "freeglut_menu.c" and
I think it is an excellent idea.  The "fgCreateMenu" function is a menu
function and except for a single assignment does not use the "freeglut"
structure at all.  What do other people think?

	I could probably make a case for moving the window creation and
destruction code from "freeglut_structure.c" to "freeglut_window.c" as well,
but it would be a bit more involved.  Any comments on that?

John F. Fay
joh...@eg...
850-729-6330 
-----Original Message-----
From: fre...@li...
[mailto:fre...@li...] On Behalf Of Richard
Rauch
Sent: Monday, September 13, 2004 9:02 PM
To: fre...@li...
Subject: [Freeglut-developer] Re: Local functions in freeglut.

I sent the below a couple of days ago, but it appears to have
been eaten entirely by the infamouse line-eater.  (^&

Reposted:

On Sat, Sep 11, 2004 at 12:27:28AM -0500, Richard Rauch wrote:
> (Since you mentioned OpenGLUT developers in an aside...)
> 
> Thanks for the note, John.
> 
> I reviewed the list.  All were already done, except for the "h"
> prefix (which, as we discussed a few days ago, I interpret to mean
> "helper", not "static"), and making the Initialize() function
> static, which I have just now done and committed.  I'm not sure
> why I wrote that note in og_internal.h, as it is not really that
> controversial.
> 
> 
> You may also wish to consider a couple more:
> 
> Along similar lines, ogDisplayMenu() was noted as only being used in
> og_structure.c, but is defined in og_menu.c.  The only place it
> is used is in ogCreateMenu(), which in turn is only called from
> one place in og_menu.c...
> 
> So if you move ogCreateMenu() into og_menu.c (which looks doable),
> you can make both functions static.
> 
> (Translate to freeglut nomenclature.)
> 
> However, the case can be made that the code is better structured
> this way, even though there is unneeded exposure of functions.
> I'm inclined, presently, to leave these where they are.  I'm leaving
> that old XXX note in place in OpenGLUT for this one.
> 
> But you may wish to move it over in freeglut.
> 
> 
> -- 
>   "I probably don't know what I'm talking about."
http://www.olib.org/~rkr/



-- 
  "I probably don't know what I'm talking about."  http://www.olib.org/~rkr/