Re: [Freeglut-developer] Minor changes for Chromium

[Richard R. <sf...@ol...>]

On Fri, Jun 25, 2004 at 03:33:16PM -0600, Brian Paul wrote:
>=20
> Hi guys,
>=20
> A Chromium user (http://chromium.sf.net/) found a problem with=20
 [...]
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /cvsroot/freeglut/freeglut/freeglut/src/freeglut_window.c,v
> retrieving revision 1.51
> diff -r1.51 freeglut_window.c
> 428,433d427
> <     glXMakeCurrent(
> <         fgDisplay.Display,
> <         window->Window.Handle,
> <         window->Window.Context
> <     );
> <=20
> 487a482,487
> >     glXMakeCurrent(
> >         fgDisplay.Display,
> >         window->Window.Handle,
> >         window->Window.Context
> >     );

I have always been a bit confused by this in the first place.
There are *two* calls to this on a new window: One is in fgOpenWindow()
and the other is in fgSetWindow().

fgOpenWindow() calls fgSetWindow().

(I checked as far back as version 1.1 of freeglut_window.c, and this was
true even then---though the CVS repository only goes back about a year.
It is also in version 1.1 of the file in the 1.3 CVS dir, though that
file is...rather different than the current freeglut_window.c (^&  That
goes back almost 3 years.  I assume that there is no source code control
for freeglut before that time.)


Is there any reason why the two OpenGL calls in fgOpenWindow() can't
be moved to occur after fgSetWindow(), and do away with this "premature"
glXMakeCurrent() altogether?  That would make the X and WIN32 code paths
a little more similar, I think...

--=20
  "I probably don't know what I'm talking about."  http://www.olib.org/~rkr/