[Freeglut-developer] More quibbles about "freeglut"

[Fay J. F C. AAC/W. <joh...@eg...>]

Gentlemen,

	On comparing my current version against CVS, I note the following:

"freeglut_init.c":

(1) On line 488, the word "attempt" in the error message is misspelled.

"freeglut_main.c"

(2) After line 323, the function "fgElapsedTime" needs to return a value.  I
suggest adding "return 0;" because we are just setting the timer.

(3) Around line 1176, the question of whether the "#if 0" code serves any
purpose does not have a good answer.  That block antedates me and probably
Steve.  I believe Chris Purnell is the longest-standing worker on the
project, and I do not know how much he did on the Windows part.  I would
simply delete it in a week or two unless somebody else says otherwise.

(4) Line 1259 has a "if ( used == FALSE )" which should be "if ( ! used )".

(5) Regarding lines 1318-1341, I agree with the comment.  Go ahead and do
it.

(6) Regarding the comment on line 1354, I say yes we could but I don't have
time to at the moment.

"freeglut_menu.c":

(7) On line 130, the comment about returning "TRUE" should perhaps be
changed to returning "GL_TRUE" since the function is of type "GLboolean".

(8) I would like to put braces around lines 186-187 because I don't like
nested "if" statements without braces.  How do other people feel about this?

"freeglut_state.c":

(9) There are a whole bunch of "return ( stuff )" constructions which should
be changed to "return stuff".  Specifically, lines 474, 479, 510, 516, 527,
532, 538, 541, 547, 557, 593, 596, 599, 607, 613, 616, 626, 629, 637, 643,
646, and 657.

"freeglut_structure.c":

(10) Line 96 has a "if ( parent != NULL )" which should be "if ( parent )".

(11) I think lines 238-242 should have braces around them (see comment 8).

(12) Lines 308 and 655 have another "if ( ... != NULL )" construction.

"freeglut_window.c"

(13) I will agree with the comment but since I know next to nothing about X
I can't do anything to fix it.

John F. Fay
joh...@eg...