[Freeglut-cvs] SF.net SVN: freeglut:[1585] trunk/freeglut/freeglut/src

[<dc...@us...>]

Revision: 1585
          http://freeglut.svn.sourceforge.net/freeglut/?rev=1585&view=rev
Author:   dcnieho
Date:     2013-04-04 10:36:44 +0000 (Thu, 04 Apr 2013)
Log Message:
-----------
some cleanup

Modified Paths:
--------------
    trunk/freeglut/freeglut/src/fg_menu.c
    trunk/freeglut/freeglut/src/fg_state.c
    trunk/freeglut/freeglut/src/mswin/fg_init_mswin.c

Modified: trunk/freeglut/freeglut/src/fg_menu.c
===================================================================
--- trunk/freeglut/freeglut/src/fg_menu.c	2013-04-04 10:20:43 UTC (rev 1584)
+++ trunk/freeglut/freeglut/src/fg_menu.c	2013-04-04 10:36:44 UTC (rev 1585)
@@ -213,10 +213,10 @@
         }
 
         menu->ActiveEntry = menuEntry;
-        menu->IsActive = GL_TRUE;  /* XXX Do we need this? */
+        menu->IsActive = GL_TRUE;
 
         /*
-         * OKi, we have marked that entry as active, but it would be also
+         * OK, we have marked that entry as active, but it would be also
          * nice to have its contents updated, in case it's a sub menu.
          * Also, ignore the return value of the check function:
          */
@@ -633,15 +633,6 @@
             /* Could reopen again in different location, as is_clicked remains false */
         }
 
-        /*
-         * XXX Why does an active menu require a redisplay at
-         * XXX this point?  If this can come out cleanly, then
-         * XXX it probably should do so; if not, a comment should
-         * XXX explain it.
-         */
-        if( ! window->IsMenu )
-            window->State.Redisplay = GL_TRUE;
-
         is_handled = GL_TRUE;
     }
 
@@ -659,8 +650,6 @@
         if (window->State.MouseX>0 && window->State.MouseY>0 &&
             window->State.MouseX<window->State.Width && window->State.MouseY<window->State.Height)
         {
-            /* XXX Posting a requisite Redisplay seems bogus. */
-            window->State.Redisplay = GL_TRUE;
             fghActivateMenu( window, button );
             is_handled = GL_TRUE;
         }

Modified: trunk/freeglut/freeglut/src/fg_state.c
===================================================================
--- trunk/freeglut/freeglut/src/fg_state.c	2013-04-04 10:20:43 UTC (rev 1584)
+++ trunk/freeglut/freeglut/src/fg_state.c	2013-04-04 10:36:44 UTC (rev 1585)
@@ -61,9 +61,6 @@
 {
     FREEGLUT_EXIT_IF_NOT_INITIALISED ( "glutSetOption" );
 
-    /*
-     * XXX In chronological code add order.  (WHY in that order?)
-     */
     switch( eWhat )
     {
     case GLUT_INIT_WINDOW_X:
@@ -161,7 +158,6 @@
 
     FREEGLUT_EXIT_IF_NOT_INITIALISED ( "glutGet" );
 
-    /* XXX In chronological code add order.  (WHY in that order?) */
     switch( eWhat )
     {
     /* Following values are stored in fgState and fgDisplay global structures */

Modified: trunk/freeglut/freeglut/src/mswin/fg_init_mswin.c
===================================================================
--- trunk/freeglut/freeglut/src/mswin/fg_init_mswin.c	2013-04-04 10:20:43 UTC (rev 1584)
+++ trunk/freeglut/freeglut/src/mswin/fg_init_mswin.c	2013-04-04 10:36:44 UTC (rev 1585)
@@ -57,9 +57,6 @@
          * Each of the windows should have its own device context, and we
          * want redraw events during Vertical and Horizontal Resizes by
          * the user.
-         *
-         * XXX Old code had "| CS_DBCLCKS" commented out.  Plans for the
-         * XXX future?  Dead-end idea?
          */
         wc.lpfnWndProc    = fgPlatformWindowProc;
         wc.cbClsExtra     = 0;

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.