#2162 feat: New Question Type Address

[Anonymous]

Originally created by: KapadiaNaitik
Originally owned by: Dhruwang

What does this PR do?

Fixes [#2089] (issue)

How should this be tested?

• Address Question Type

Checklist

Required

• Filled out the "How to test" section in this PR
• Read How we Code at Formbricks
• Self-reviewed my own code
• Commented on my code in hard-to-understand bits
• Ran pnpm build
• Checked for warnings, there are none
• Removed all console.logs
• Merged the latest changes from main onto my branch with git pull origin main
• My changes don't cause any responsiveness issues

Appreciated

• If a UI change was made: Added a screen recording or screenshots to this PR
• Updated the Formbricks Docs if changes were necessary

[Anonymous]

Originally posted by: vercel[bot]

@KapadiaNaitik is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

[Anonymous]

Originally posted by: CLAassistant

All committers have signed the CLA.

[Anonymous]

Originally posted by: github-actions[bot]

Thank you for following the naming conventions for pull request titles! 🙏

[Anonymous]

Originally posted by: jobenjada

Hey! Thanks for the rapid turnaround 🚀

I cannot run nor build it:

Please fix this, happy to review after 🤓

Cheers
Johannes

[Anonymous]

Originally posted by: jobenjada

Hey mate!

Unfortunately, it's not working properly. If you try to fill in all fields, only the first two work as they are supposed to:

Please test it through for both web and in-app surveys 🤓

Thanks a lot!

[Anonymous]

Originally posted by: jobenjada

Hey @KapadiaNaitik

overall, it looks good! I refactored the Address component a bit to reduce redundant code.

Please rework how the addresses are displayed so it matches the mock up. It's important for user to be able to really easily copy the address out of Formbricks without the name of the input field. The way you solved it right now doesn't allow for that:

vs

and

Thanks for your work! 🤝

[Anonymous]

• assigned_to: KapadiaNaitik

[Anonymous]

• assigned_to: Dhruwang

[Anonymous]

Originally posted by: jobenjada

Hey @Dhruwang

here is what I noticed:

1. No autofocus on first field. Makes keyboard usability hard (pls add to the Question Creation doc in case its not part of it)

---

1. The required states aren't synced
   If any of the question fields is required, the whole question should be required, shouldn't it?

---

Please also test once for in-app surveys.

---

The rest looks good!

[Anonymous]

Originally posted by: Dhruwang

Fixed both issues 😊

https://github.com/formbricks/formbricks/assets/67850763/afe67a45-c678-45a8-aca9-4ff51cb5ef7d

https://github.com/formbricks/formbricks/assets/67850763/9d1d21c3-c2ec-4a96-a20c-82ac93cd0514

[Anonymous]

Originally posted by: jobenjada

/award 150

[Anonymous]

Originally posted by: oss-gg[bot]

Awarding KapadiaNaitik: 150 points!