Menu

#1046 Support of Raspberry SPS

1.8
closed-accepted
nobody
IO (1)
FORTE
New_Feature
Normal
2015-11-29
2015-09-22
Gerd Kainz
No

There exists a nice system called Raspberry SPS (raspberry-sps.de). The attached paches implement support for the provided I/O boards. The support has been added to the IDE and FORTE.

Vorgänger: 1503 (3b44c7cd674d) Merge with 1.7.x
Vorgänger: 144 (70aea06a1af5) Merge

2 Attachments

Discussion

  • Gerd Kainz

    Gerd Kainz - 2015-09-23

    Attached is a type correction of the IW and QW blocks.

     
  • Gerd Kainz

    Gerd Kainz - 2015-10-01

    Corrected the access method for the ADCes of the Raspberry SPS.

    Now, everything works fine.

     
  • Monika Wenger

    Monika Wenger - 2015-10-02

    thank you for the patches I added patch 146 in cset[fordiac-lib:19ed6a] the other patches will be added soon

     

    Related

    Commit: [19ed6a]

  • Zoitl Alois

    Zoitl Alois - 2015-10-06

    I finally found some time to review the FORTE patches. First of all thanks for the work it is great to have more I/O support. There are some issues I would discuss with you before applying the patches:

    • From a code reuse perspective wouldn't it be better to merge the CWordAccess with CProcessInterface?
    • You implemented only the REQ/CNF interface for IX. In the latest version there is also in IND output event. Would it be much effort to add it?

    BR,
    Alois

     
  • Gerd Kainz

    Gerd Kainz - 2015-10-06
    • Merging CWordAccess and CProcessInterface would make sense, but this requires the implementation of IX, QX, IW and QW on all platforms. Alternatively, a common base class of CProcessInterface and CWordAccess would make sense.
    • I know about IND but not how it works. If I get that information, implemenation shall be easy.
     
    • Zoitl Alois

      Zoitl Alois - 2015-10-06

      Merging CWordAccess and CProcessInterface would make sense, but this requires the implementation of IX, QX, IW and QW on all platforms.

      Not necessarily. If IW and QW just use two additional functions of CProcessinterface (i.e, writeWord, readWord) only the platforms providing IW and QW need to add these function blocks. As the design pattern we are using here is half template based this should scale quite flexible and platforms not supporting IW and QW would not be affected.

       
  • Zoitl Alois

    Zoitl Alois - 2015-11-29
    • labels: --> IO
    • status: open --> closed-accepted
    • Milestone: Backlog --> 1.8
     

Log in to post a comment.

MongoDB Logo MongoDB