Problem with programatically causing a stop operation in a 4DIAC application via Forte

[Nishchal Kush]

Calling changeFBExecutionState(cg_nMGM_CMD_Stop) on the E_RESTART instance does not actually stop the application.
I can make an application stop by calling sendOutputEvent(E_RESTART::csm_nSTOPID) on my E_RESTART instance (with my start function being a friend of E_RESTART). It does stop the application, but does not increment the monitored STOP output of the E_RESTART function block shown in the 4DIAC IDE.
Maybe what I want to do is not possible?

[Zoitl Alois]

Hi, it seams that you found an issues in E_RESTART. The problem is that the STOP command deactivates to early the event handling so the sending of the STOP event is not peferformed. I'll try to get you an updated version of the E_RESTART later this day.

Alois

[Zoitl Alois]

Please find attached an updated version of E_RESTART which should handle your situation correctly. Could you be so kind and give it a try.

[Nishchal Kush]

Thanks, but the result is the same. I can now use changeFBExecutionState(cg_nMGM_CMD_Stop) rather than call sendOutputEvent(E_RESTART::csm_nSTOPID) directly. The application stops, but the monitored E_RESTART STOP output does not change from zero.

[Nishchal Kush]

I've attached a 4DIAC view of the simple test app I'm using. Each of COLD, WARM, STOP E_RESTART outputs are connected to E_CYCLE blocks. The snapshot shows the view after deployment and stop.

[Zoitl Alois]

That is strange because sendOutputEvent should definitly result in an increas in the count. How are you invoking the changeFBExecutionState(cg_nMGM_CMD_Stop)? Is there a way that I can recreate it?

[Nishchal Kush]

int stop (RMT_DEV * dev)
{
    RMT_RES * res = &(dev->MGR);
    unsigned failed = 0;
    // Set STOP for E_RESTART function block
    forte::core::CFBContainer::TFunctionBlockList & fbList = res->getFBList();
    for (CResource::CFBContainer::TFunctionBlockList::Iterator itr = fbList.begin(); itr != fbList.end(); ++itr)
    {
        CFunctionBlock * fb = (*itr);
        if (fb->getFBTypeId() == g_nStringIdE_RESTART)
        {
            // NOTE it does execute in here when fbList = res->getFBList() but not dev->getFBList()
            if (fb->getState() != CFunctionBlock::e_RUNNING)
                failed++;
            else
            {
                E_RESTART * e = static_cast<E_RESTART *>(fb);
                EMGMResponse result = fb->changeFBExecutionState(cg_nMGM_CMD_Stop); // results in startNewEventChain(fb)
                if (result != e_RDY)
                    failed++;
                //assert(fb->getState() == CFunctionBlock::e_STOPPED); // false. TODO should be true
            }
        }
    }
    return failed ? 0 : 1;
}

[Zoitl Alois]

Hi,

in this code you are sending a stop command to the E_RESTART of the RMT_RES. With that you will shutdown the communication between 4DIAC-IDE and the FORTE as this will result in an INIT- event for the SERVER FB that is located in the DM_KRNL FB. The result of this is that 4DIAC IDE will not got monitoring updates.

The RMT_RES will be correctly shutdown on the shutdown of the device. In other cases you should not do anything withit. Therefore RMT_RES is also not available through managment commands to be changed by the tool (e.g., you can not add FBs or monitor it).

I think what you should do is to get the fbList of the DEV and search there for the RES with your name. Or maybe all Resources there and stop the E_RESTARTS in them.

[Nishchal Kush]

Thanks. The functional stop operation is:

int stop (RMT_DEV *rmtDev)
{
    unsigned failed = 0;
    // Set STOP for each E_RESTART function block in each resource
    forte::core::CFBContainer::TFunctionBlockList & resList = dev->getFBList();
    for (CResource::CFBContainer::TFunctionBlockList::Iterator itr = resList.begin(); itr != resList.end(); ++itr)
    {
        CFunctionBlock * fb = (*itr);
        if (fb->getFBTypeId() != g_nStringIdEMB_RES)
            continue;
        CResource * res = static_cast<CResource *>(fb);
        forte::core::CFBContainer::TFunctionBlockList & fbList = res->getFBList();
        for (CResource::CFBContainer::TFunctionBlockList::Iterator itr2 = fbList.begin(); itr2 != fbList.end(); ++itr2)
        {
            fb = (*itr2);
            if (fb->getFBTypeId() == g_nStringIdE_RESTART)
            {
                if (fb->getState() != CFunctionBlock::e_RUNNING)
                    failed++;
                else
                {
                    EMGMResponse result = fb->changeFBExecutionState(cg_nMGM_CMD_Stop);
                    if (result != e_RDY)
                        failed++;
                }
            }
        }
    }
    return failed ? 0 : 1;
}

Note there is an error in the E_RESTART::executeEvent function that you supplied earlier. if csmSTOPID == mEventToSend then the changeFBExecutionState should be cg_nMGM_CMD_Stop.

[Zoitl Alois]

Thanks for noting the error. I will fix this and push it to the repository.

[Zoitl Alois]

What I forgot to ask is if it works now correctly?

[Nishchal Kush]

Yes, it is now working.

[Zoitl Alois]

ah good.