FMSLogo Code

Fix a comment

Update the baseline testlog based on a recent test pass.

Fix a recent regression where, if treeifying a procedure resulted in loading a file that
redefined the procedure that was being treeified, the act of redefining the procedure
would free the tree that had been created thus far, causing a freed memory read.

The fix is to explicitly hold a reference the tree as it's being created, instead of
assuming that the procnode would keep a reference on it.

Fix the name of EVALTEST.SILENTLOADFROMTREEIFY (late change)

Add EVALTEST.SILENTLOADFROMTREEIFY
This is a test for a new regression that prevents ORIENTATIONTEST from running.
ORIENTATIONTEST test this bug incidentally, but EVALTEST.SILENTLOADFROMTREEIFY tests it explicitly.

Change the way reeification is implemented so that only trees are untreeified.
This enables the addition of "assert(is_tree(tree))" in settreepair__tree, which may make it easier to identify future bugs.

Add the output from newly added tests to the expected testlog.

Remove a misleading comment

This contains some follow-up fixes for changes made in r6323.

The bodylines within a procedure's bodylists are no longer marked as a TREE,
but there was still some code that tried to use and access the tree and this
no longer worked. This includes the logic for re-treeifying a procedure if
definitions changed while they're running.

This change also adds some asserts to find when a non-tree is treated as a TREE
and when a non-line is treated as a LINE. This should make it easier to find
and debug similar problems.

Add EVALTEST.ERASEWHILERUNNING.
This is a focused test for a specific clause in a if statement in eval.cpp.