FMSLogo Code

Fix the name of EVALTEST.SILENTLOADFROMTREEIFY (late change)

Add EVALTEST.SILENTLOADFROMTREEIFY
This is a test for a new regression that prevents ORIENTATIONTEST from running.
ORIENTATIONTEST test this bug incidentally, but EVALTEST.SILENTLOADFROMTREEIFY tests it explicitly.

Change the way reeification is implemented so that only trees are untreeified.
This enables the addition of "assert(is_tree(tree))" in settreepair__tree, which may make it easier to identify future bugs.

Add the output from newly added tests to the expected testlog.

Remove a misleading comment

This contains some follow-up fixes for changes made in r6323.

The bodylines within a procedure's bodylists are no longer marked as a TREE,
but there was still some code that tried to use and access the tree and this
no longer worked. This includes the logic for re-treeifying a procedure if
definitions changed while they're running.

This change also adds some asserts to find when a non-tree is treated as a TREE
and when a non-line is treated as a LINE. This should make it easier to find
and debug similar problems.

Add EVALTEST.ERASEWHILERUNNING.
This is a focused test for a specific clause in a if statement in eval.cpp.

Cleanup: Stop calling untreeify_procnode() in release_all_objects()
This is no longer needed, now that treeifying a procnode no longer creates circular references.

Fix Bug #620; APPLY no longer leaks when running named slot templates.

The fix is not to make LINE nodes when treeifying a procedure.
In the context of a treeified procedure, LINE nodes would create a cycle
that would leak memory unless the procedure is explicitly untreeified.

In the case where APPLY was given named slot templates (a body list),
APPLY creates an anoymous procedure and there's no good place in the
evaluator to untreeify it. In this case, some nodes were leaked.

This was a regression introduced by r1570, when an untreeify_line
was removed from the logic for treeifying a proceedure, following what
UCBLogo does. However, UCBLogo doesn't leak nodes because
it has a mark-and-sweep garbage collector that can handle cycles.

The new fix doesn't re-add the explicit untreeification. Instead, it
extracts a helper function from untreeify_line() that doesn't mark the
line as a TREE or create the cycle. To me, it makes more sense not to
create the cycle than to create a cycle then immediately undo that work.

Include the reference count of nodes in debug_dump_node.
This helps to debug some memory leaks and freed memory reads/writes.