#175 Support generic tools

[Thomas Luebking]

The patch series (3) allows to add random toolbuttons to toolbar.tools what can be used to add a win95-a-like "start" button but also hooks for custom menus (exposing un/mounts via udisks, select a network, ...) or a volume button that toggles master on button 1, opens an alsamixer xterm on 2 and raises/lowers volume on 5/4 ... or whatever you can come up with.

[Mathias Gumz]

i am in favour of this one. i wanted to implement this some time ago, never found the time.

anyway:

• FbTk::StringUtil::stringtok(tools, *m_rc_tools, ", ");
• FbTk::StringUtil::stringtok(tools, *m_rc_tools, ",");

this changes semantics. whats the point of not allowing " " (spaces) as the delimiter?

the usage is also a bit underdocumented.

[Thomas Luebking]

Parameters,
toolbar.tools: iconbar, systemtray, clock, Devices:CustomMenu $HOME/.fluxbox/menu.mounts

the space delimiter makes that an arbitrary list of invalid commands.
I mentioned the change in the commit message because I'm aware that it could be a deal-breaker.
An alternative could be to introduce (except if it's already there ;-) some aliasing to the config, so that you could
alias devicebutton: Devices:CustomMenu $HOME/.fluxbox/menu.mounts
...
toolbar.tools: iconbar, systemtray, clock, devicebutton

[Mathias Gumz]

i toyed around a while ago with something like:

toolbar.tools: iconbar, shellcmd.xyz, clock
toolbar.tools.shellcmd.xyz = the real command

keep a common prefix ("shellcmd", "whatever") which defines the "type" and a suffix "xyz" to give the id / alias which is then used to lookup whats actually wanted.

[Thomas Luebking]

The alias approach is indeed better - allows for sed/parately editable labels and re-usage of buttons.
Since you didn't comment on the multibutton support (which I assume somewhat crucial as feature anyway), I squashed commits to not clutter the git history.

Sorry for the delay.

[Thomas Luebking]

Frt, this is also in https://github.com/luebking/fluxbox
Anything else that should be improved about the patches?

[Mathias Gumz]

i need to shovel some spare time, somewhere to test the pending patches / features. sorry about that

[Thomas Luebking]

https://github.com/luebking/fluxbox/commit/647b933054eaf2741ee08b42dd0d9261db8b716c

The patch extends the feature with a (remote) command to alter the label at runtime.

[Thomas Luebking]

Moved to #193 (added git branch ;-)

[Mathias Gumz]

[#193] was merged and implements this.