#1130 Patch: Shaped toolbar drawn incorrectly for TOPCENTER placement

[Peter Ganzhorn]

With fluxbox v1.3.7 I noticed the rounded corners on the (a.k.a. shaped) toolbar being drawn incorrectly when placement TOPCENTER is set.
The corners should be drawn on the BOTTOM of the toolbar for this placement and not on the TOP.
The placments TOPLEFT and TOPRIGHT are unaffected and show the rounded corners correctly at the BOTTOM.

I tracked the issue down to the table _values[] in Toolbar.cc which contains incorrect placement information for only the TOPCENTER position.
I also took the liberty to align the table a bit differently in order to improve readability and hopefully make it easier to spot errors in there in the future.

See attached patch which fixes the issue.

best regards,
Peter Ganzhorn

[Mathias Gumz]

good catch.

[Mathias Gumz]

mhh .. do you want to provide a git-format-patch or do you want me to apply this patch an reference to you by name only?

[Peter Ganzhorn]

Although this really is a minor bug my ego wants me to be famous for contributing to fluxbox, so here is a git-format-patch. I actually never created one before, so I hope I didn't mess up on this.

[Mathias Gumz]

perfect: http://git.fluxbox.org/fluxbox.git/commit/?id=95b7c77409ca38b19675536774709d8c5dac4692

[Peter Ganzhorn]

I have one final thought on this:
Imagine the toolbar being placed at e.g. TOPLEFT. With the current code, both the BOTTOMLEFT and BOTTOMRIGHT corners will be drawn rounded when toolbar.shaped=true.
But since the toolbar is sitting at the edge of the screen in this case, wouldn't it be looking better to draw only the BOTTOMRIGHT corner rounded in this case since this would be the only corner not touching a border of the screen?

So what I'm proposing is to draw only corners not touching any edges of the screen rounded when toolbar.shaped=true.
If you like this idea, I'd be glad to make the neccessary changes and post another patch.

[Mathias Gumz]

do it :)