#53 Pipistrelle does not handle component correctly

[John Barnes]

This problem seen with the same Component Builder generated .omi and .fcs files as Ticket #52. These files are also attached here. The workaround described in Ticket #52 was applied to the code.

To reproduce the problem:

• start Pipistrelle and add the component using the attached .omi file
• right-click on the CB_Pond component and click on the command Set as "Get Values call" ...
• select OutFlow in the Select dialog and confirm
• click on Run
• click on Pull Run

The CB_Pond component is not included in the Run Composition view. Attached screenshot RunComposition.PNG shows this.

If you then click on Run | Start, Pipistrelle fails with an exception as shown in the attached Capture2.PNG screenshot.

As a workaround I added these lines of code to FluidEarth2_SDK_CoreStandard2\BaseComponent.cs at line 153 (just before the statement _initialised = true):

            foreach (var i in Inputs)
                if (i is BaseExchangeItem)
                    ((BaseExchangeItem)i).Component = this;

            foreach (var i in Outputs)
                if (i is BaseExchangeItem)
                    ((BaseExchangeItem)i).Component = this;

Opinions on whether that is a legitimate change would be welcome.

With this workaround in place, the workaround described in Ticket #52 becomes redundant and can be removed.

[Anonymous]

This appears to simply be making sure that all the inputs and outputs for a component have their Component attribute correctly set. This is legitimate. Why it should result in an indexing error as per the screen capture defeats me currently :-) Anyway, seems a legit change.