Menu

#52 Crash in CompositionView.cs on setting Get Values call

Pipistrelle 2.1
open
nobody
None
1
2014-08-04
2014-06-02
John Barnes
No

This problem seen while building a composition using .omi and .fcs files (attached) generated by Component Builder for the C# implementation of the Pond tutorial example.

To reproduce the problem:

  • start Pipistrelle and add the component using the attach .omi file
  • right-click on the CB_Pond component and click on the command Set as "Get Values call" ...
  • select OutFlow in the Select dialog and confirm

Pipistrelle crashes at line 241 of CompositionView.cs because output.Component is null. See attached screenshot Capture.PNG for details.

As a temporary workaround so that I could make progress I changed line 241 to read:

            var componentItem = _composition.GetItem(component);

Opinions on whether that is a legitimate change would be welcome.

4 Attachments

Related

Bugs: #52

Discussion

  • Anonymous

    Anonymous - 2014-08-01

    I can't reproduce this - when i try to select OutFlow there is nothing to select... also the CompositionView.cs lines 240-242 read:
    foreach (var item in _composition.ExchangeItems)
    if (item.Interface == IdentifiableItemType.IBaseOutput
    && ((IBaseOutput)item.ItemInstance).Component == null)

    which seems to have little relationship to the change? The line you have used is available on line 255 of the same file?

     
  • John Barnes

    John Barnes - 2014-08-04

    Sorry about the typo - the line I changed was 1241 (as confirmed in capture.PNG).

    I have set this up again using the files attached to to this Ticket in a fresh folder and can select OutFlow OK - see Capture2.PNG attached.

    The problem described in this Ticket disappears when the fix described in Ticket #53 is applied, so I suggest we close this Ticket on that basis.

     
    • Anonymous

      Anonymous - 2014-08-04

      Ok – sounds good to me!

      From: John Barnes [mailto:johnbarnes4@users.sf.net]
      Sent: Monday, August 04, 2014 11:11 AM
      To: [fluidearth:bugs]
      Subject: [fluidearth:bugs] #52 Crash in CompositionView.cs on setting Get Values call

      Sorry about the typo - the line I changed was 1241 (as confirmed in capture.PNG).

      I have set this up again using the files attached to to this Ticket in a fresh folder and can select OutFlow OK - see Capture2.PNG attached.

      The problem described in this Ticket disappears when the fix described in Ticket #53 is applied, so I suggest we close this Ticket on that basis.

      Attachment: Capture2.PNG (60.2 kB; image/png)


      [bugs:#52]http://sourceforge.net/p/fluidearth/bugs/52 Crash in CompositionView.cs on setting Get Values call

      Status: open
      Group: Pipistrelle 2.1
      Created: Mon Jun 02, 2014 12:50 PM UTC by John Barnes
      Last Updated: Fri Aug 01, 2014 11:11 AM UTC
      Owner: nobody

      This problem seen while building a composition using .omi and .fcs files (attached) generated by Component Builder for the C# implementation of the Pond tutorial example.

      To reproduce the problem:

      • start Pipistrelle and add the component using the attach .omi file
      • right-click on the CB_Pond component and click on the command Set as "Get Values call" ...
      • select OutFlow in the Select dialog and confirm

      Pipistrelle crashes at line 241 of CompositionView.cs because output.Component is null. See attached screenshot Capture.PNG for details.

      As a temporary workaround so that I could make progress I changed line 241 to read:

              var componentItem = _composition.GetItem(component);
      

      Opinions on whether that is a legitimate change would be welcome.


      Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/fluidearth/bugs/52/https://sourceforge.net/p/fluidearth/bugs/52

      To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/https://sourceforge.net/auth/subscriptions

      This message has been scanned for viruses by MailControlhttp://www.mailcontrol.com/, a service from BlackSpider Technology

      Click herehttps://www.mailcontrol.com/sr/tnYpaeI8KjbGX2PQPOmvUj!GOBh06pKKzZm1x8YGF4uqrhlhIWhOFcA7Bd8p5aHWalPjxinsAkBSWoTyPktGDA== to report this email as spam.


      HR Wallingford and its subsidiaries uses faxes and emails for confidential and legally privileged business communications. They do not of themselves create legal commitments. Disclosure to parties other than addressees requires our specific consent. We are not liable for unauthorised disclosures nor reliance upon them.
      If you have received this message in error please advise us immediately and destroy all copies of it.

      HR Wallingford Limited
      Howbery Park, Wallingford, Oxfordshire, OX10 8BA, United Kingdom
      Registered in England No. 02562099


       

      Related

      Bugs: #52

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB