|
From: James T. <zak...@ma...> - 2017-01-17 22:04:30
|
> On 16 Jan 2017, at 19:49, jsb <fli...@he...> wrote: > > could you please sketch what kind of changes your review would probably > result in? Depending on that I would decide were I want put my > resources. I added canvas gui api to the wiki because I was missing it > and tired of scrolling the code every now and then. I left some things > open that I did not understand at first glance. The simpler answer is I don’t know, so spend resources on what you think best. My intuition is the current style system is overkill, but that the layout code will need some enhancements. So I would avoid both those areas for now. Adding missing widget types is probably safe, but if you propose them here we can discuss their API to hopefully keep it stable even if the implementation changes. > > btw. who do I have to bribe to get my merge requests handled? ;-) It > seems other commits find their way into fgdata much faster :s Which merge requests do you mean? I’ve been dealing with all the ones I can, or am waiting for feedback. Kind regards, James |