Getstart Merge Request #32: Text correction 2 (merged)

[Florent Rougon]

Pushed as is (and good catch for the old keyboard.xml advice!), but little comments:

1) I'm not competent here, but are you sure that --prop:/sim/rendering/draw-otw=false does nothing? There are a few matches in flightgear/src/Scenery/scenery.cxx, incl. this:

    } else if (name == "draw-otw") {
      // legacy setting but let's keep it working
      fgGetNode("/sim/rendering/draw-mask")->setBoolValue("terrain", b);
      fgGetNode("/sim/rendering/draw-mask")->setBoolValue("models", b);

That said, I believe your change in the .tex file is good regardless.

2) This:

(see Section~\ref{view-direction-mode},~\nameref{view-direction-mode}.)

If it were me, I wouldn't make Section start with a capital, and wouldn't put the second tie (~). Reason:

• a break before the \nameref... wouldn't be that bad, I think;
• when there are not enough legal breakpoints in a given area of a paragraph, TeX can't find a good place to break the line(s), so this is likely to result in an overfull or underfull \hbox, which will probably be worse than the harmless line break you were trying to prevent in the first place (here, the one before \nameref...).

Not a big deal, don't worry; just take note for next time.

As an aside: I believe the compilation logs are much much nicer now that wrapfig has been removed. :-)

[Roman Ludwicki]

About draw-otw I mean that from long time this way doesn't work at all, this options doesn't disable the world from rendering. It should but nothing changes from user perspective. I also tested with next build.

[Florent Rougon]

Okay, okay, as I said, I'm not competent on this point. :) Thanks.