Menu

FGData Merge Request #44: Fix nuking of property-scale's default factor by the joystick-config dialog (merged)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

Florent Rougon wants to merge 0 commits from /u/frougon/flightgear-fgdata/ to next, 2016-01-08

Hello,

This commit fixes the following bug: if a joystick axis binding is using property-scale without any explicitly-defined factor, then opening the joystick configuration dialog creates an empty 'factor' node, which renders the joystick axis inoperant (the effective factor value being 0). Full details are in the commit log.

Thanks for considering. :-)

Commit Date  

Discussion

  • James Turner

    James Turner - 2016-01-08

    Looks good, thanks!

     
  • Florent Rougon

    Florent Rougon - 2016-01-08

    Thank you! I submitted another merge request based on this commit (https://sourceforge.net/p/flightgear/fgdata/merge-requests/45/), but SF counts 2 commits in the second merge request, probably because the first one (from this page) is not merged yet. I hope it will work...

     
  • Florent Rougon

    Florent Rougon - 2016-01-08

    Hmm, the Cancel button seems to only apply to comments. I don't see how to cancel the request myself, so I'll leave this up to you (unless you know of a way I haven't found)...

     
  • James Turner

    James Turner - 2016-01-08
    • Status: open --> merged
     

Log in to post a comment.

MongoDB Logo MongoDB