Menu
▾
▴
FGData Merge Request #309: Fix hpa displayed values at KAP140 on c172p (merged)
Merging...
Merged
Something went wrong. Please, merge manually
Checking if merge is possible...
Something went wrong. Please, merge manually
Jimis Hol wants to merge 1 commit from /u/jimishol/flightgear-fgdata/ to release/2020.3, 2024-03-03
Fixing rather typo so as the right value of hpa to be displayed when flying a c172p.
| Commit | Date | |
|---|---|---|
|
[d85c13]
(Fix_Hpa_displayed_values_at_KAP140_on_c172p)
by
jimishol
Fix hpa displayed values at KAP140 on c172p |
2023-05-04 06:54:26 | Tree |
Fixes to the C172 need to happen in its upstream repo, and then get synced back to FGData; if we make a local fix directly it will get lost.
@wlbragg can you advise Jimis the correct way to handle this?
Fixes to the C172 need to happen in its upstream repo, and then get synced back to FGData; if we make a local fix directly it will get lost.
@wlbragg can you advise Jimis the correct way to handle this?
Thank you.
Looked for it and as I understood, the repo is at https://github.com/c172p-team/c172p/tree/release/2020.3
But, anyway that fix will not be needed in new https://github.com/c172p-team/c172p/tree/release/2020.4 release., as it uses totally different code for that display. May be i will try to contact the c172p repo in github.
Ok, i created a pull request in github. If you please just inform me when it is safe to delete my fixing branch from sourceforge.net.
Thank you
Last edit: Jimis Hol 2023-05-04
Yep, we'll take care of it. I hope to cut a new release tag in the next month.
This has been fixed in the tagged release on GitHub at https://github.com/c172p-team/c172p/releases/tag/version%2F2020.3
@jmturner I don't know if this needs to be backported to the 2020.3 release of fgdata or who would do this?
It's normally Stuart that has done it, but in principle anyone can. Is it just a single commit or are there lots of changes on the release?
I checked and it looks like there may be as many as 4 bug fixes on the 2020.3 branch.
Okay @stuartbuchanan can you comment on the procedure to update the version in FGData (on 2020.3)? Either do it or summarise for someone else to follow, I guess.
We pulled the 2020.3 branch from the c172p-team repository on 5th August 2023, which included these fixes, so closing this merge request.
For reference, the commit was 64c07d5701ada38ca4b50a0b5bb12afcab896df3