#568 Old and new runway printed to screen on sim reset

[Anonymous]

Originally created by: gijsrooy

What steps will reproduce the problem?
1. Launch FlightGear at an airport.
2. Reposition yourself to either the same airport, or another one. It doesn't matter.

What is the expected output? What do you see instead?
You'll see the message "You are on runway ..." printed twice. First line contains the runway that you launched this FlightGear session, the second lists the runway that you've "teleported" yourself to.

On the first startup in a session, only one runway is shown.

What FlightGear version (or GIT date)?
Today's

[Anonymous]

Originally posted by: cumuluni...@gmail.com

Not observed here on Linux...

[Anonymous]

Originally posted by: gijsrooy

I added the following line to Nasal/screen.nas

  var rwy = n.getValue();
+ print("You are on runway "~rwy);
  if (rwy == nil)

That gives me the following message in the console, when changing airport in-sim.

You are on runway 22
passed invalid index (0) to FGRouteMgr::jumpToIndex
You are on runway 27

Where rwy 22 is the one I launched FlightGear at, and 27 is the one I'm placed at after changing airport.

The route manager message always comes in between, so I suspect it has something to do with that...

[Anonymous]

Originally posted by: sco...@googlemail.com

I have the same behavior with those versions:
FlightGear version: 2.4.0
SimGear version: 2.4.0
PLIB version: 185

OS: Gentoo Linux

Only the startup message is repeated. So starting on runway 24, and relocating to rwy 06 two times will produce the same two messages:
You are on runway 24
You are on runway 06

[Anonymous]

Originally posted by: kanto...@gmail.com

Confirmed here too, git 06-01-12

[Anonymous]

Originally posted by: bre...@gmail.com

I also remember seeing that quite regularly.
However, I'm pretty sure it's unrelated to the "passed invalid index (0) to FGRouteMgr::jumpToIndex" message. That's a different issue which could be solved in several ways (easiest is just to remove/downgrade that warning message).
It's just that the route manager happens to be the only other subsystem which prints an (error/warning) message during initialization. There'll be loads of other subsystem initializations happening at about the same time.

Status: Accepted

[Anonymous]

Originally posted by: zakalawe@mac.com

Yeah, I don't think the route-manager message is related - it doesn't do anything to the active runway apart from read it. (I'm assuming the on-screen message does not reference a route-manager property)

[Anonymous]

Originally posted by: bre...@gmail.com

Fixed:
http://www.gitorious.org/fg/fgdata/commit/5699d3f08066f2ea1524e63d0983d0c6ca315d3e

Needed to protect the property from being written by the magic
FGGlobals::restoreInitialState" which just copies & restores the entire property tree
on sim reset. This triggering the print-runway-to-screen listener, actually showing
the _old_ runway first. Then the _new_ runway was calculated during the reinit and
explicitly set - which triggered the listener a second time...

Summary: Old and new runway printed to screen on sim reset
Labels: Milestone-2.6.0
Status: Fixed

[Anonymous]

Originally posted by: gijsrooy

Such a simple fix :)
Thanks for finding it!

Status: Verified