#478 Bo105 and EC135 Nasal error

[Anonymous]

Originally created by: gijsrooy
Originally owned by: gijsrooy

What steps will reproduce the problem?
1. Load the Bo105 or EC135
2. Try to start the heli with }

What is the expected output? What do you see instead?
While FlightGear loads:
Nasal runtime error: nil used in numeric context
  at C:/FlightGear/fgdata/Aircraft/ec135/Models/ec135.nas, line 46
  called from: C:/FlightGear/fgdata/Aircraft/ec135/Models/ec135.nas, line 53

And on the } press:
Nasal runtime error: No such member: startup
  at /input/keyboard/key[125]/binding, line 1

What FlightGear version (or GIT date)?
October 23 fgdata and Win32 build.

[Anonymous]

Originally posted by: aeitsch...@yahoo.de

Noticed as well- maybe the changes related to Cmake is the cause, but I don't know.

A temporary fix is to uncomment those following lines:

var nav_light_loop = func {
    if (nav_light_switch.getValue())
        nav_lights.setValue(visibility.getValue() < 5000 or sun_angle.getValue() > 1.4);
    else
        nav_lights.setValue(0);

    settimer(nav_light_loop, 3);
}

nav_light_loop();

Cc: -aeitsch...@yahoo.de zakalawe@mac.com
Status: Accepted

[Anonymous]

Originally posted by: aeitsch...@yahoo.de

Seems to be fixed with the latest Jenkins-built- can someone confirm it?

Status: Testing

[Anonymous]

Originally posted by: gijsrooy

No time to try a new build, but I can confirm that removing the lines from comment #1 made it start. We used it in Lelystad ;)

[Anonymous]

Originally posted by: aeitsch...@yahoo.de

No, I was wrong, it is still there. *sigh*

Status: Accepted

[Anonymous]

Originally posted by: zakalawe@mac.com

I guess this is caused by me refactoring the sky init code, I've made one piece happen lazily, that I thought only affected rendering, but due to some 'interesting' encapsulation, it's visible via properties too. Hmm.

[Anonymous]

Originally posted by: tdo.bran... (code.google.com)@gmail.com

another way to fix this is to replace the line:
nav_lights.setValue(visibility.getValue() < 5000 or sun_angle.getValue() > 1.4);
with:
nav_lights.setValue((visibility.getValue() or 0.0) < 5000 or (sun_angle.getValue() or 0.0) > 1.4);

However this still means that the light loop is not necessarily started automatically when it ought to

[Anonymous]

Originally posted by: zakalawe@mac.com

Hopefully fixed for real by https://gitorious.org/fg/flightgear/commit/e89699acef6fc404b313d8dd5dd9660e6cf42597 - this restore the old behaviour, where the default value (0) is available during Nasal init. Unfortunately, I can't compute a valid value early, since there's an unpleasant dependency on the view code.

Status: Fixed