#2810 AI flightplan erases runway causing assert fail segfault

[Huntley Palmer]

Seen departing KOQU, Kingston RI for KPVD, providence RI apparently when a flightplan is being created for an AI departure from KBGR Maine. The backtrace says threshold T1 doesnt exist, KBGR has runways 15, 33 but the wind is indicated at 150. Is it possible the AI runway being erased in fallbackGetActiveRunway causes the asser to fail ? Tks

[James Turner]

Pinging Keith about this one.

[James Turner]

Okay this one is not really on Keith, we should swap those asserts for an exception throw.

Looking at TerraSync the threshold.xml looks correct (two thresholds defined), Huntely can you verify the threshold file is correct locally for you? The 'only' way I can imagine this failing is if the XML somehow got messed up and won't parse?

[Huntley Palmer]

Good point, I have Dave Megginson's scenery eatlier in the search order, which adds a runway, 'H1', heading 20 deg but with only one threshold. I'll retry with basic terrasync scenery, Thanks.

[James Turner]

Is H1 actually a helipad, I wonder? We dont have support for helipads in threshold.xml right now.

[Huntley Palmer]

Yes, according to Skyvector 100x100 but no bearing mentioned there.

[Huntley Palmer]

I've been testing various fg-scenery commands, only this .fgfsrc command below causes the failure:
--fg-scenery=/blds/fgfs-canada-us-scenery:/fgfs/scenCust:/fgfs/scenTerr

I can't see any other combination of the three, alone or in pairs causing a problem. 'scenCust' is a sparse folder with the older RI/Mass scenery project and with symlinks to Airport and NavData where a few procedures and revised thresholds are stored for testing, debug.

There's no reference to KBGR in scenCust but the segfault always occurs with the same AI flight , from KBGR to KDCA.

Since I can't reproduce the fault with any combo of David's scenery and or Terrasync it's a 'cannot reproduce' if you wish to close the ticket, Thanks.

[Huntley Palmer]

I Take that back ! I see the segfault with:
--fg-scenery=/fgScen/fgfs-canada-us-scenery:/fgfs/scenTerr
Am now trying
--fg-scenery=/fgScen/fgfs-canada-us-scenery

[James Turner]

@lightwork have you tried with the fixes I pushed a few days ago to the parsing? They shoudl stop the crash; if it's still crashing please provide a new backtrace.

[Huntley Palmer]

No crash ! The log reports:
341.16 [WARN]:general /fgfs/simgear/simgear/debug/ErrorReportingCallback.cxx:93: Error:bad data from from TerraSync::Airport threshold data could not be loaded:Mis-configured runway threshold data: exactly two thresholds must be defined
at /blds/fgfs-canada-us-scenery/Airports/K/B/G/KBGR.threshold.xml,
line 21
Path "/blds/fgfs-canada-us-scenery/Airports/K/B/G/KBGR.threshold.xml"

Many Thanks.