#2386 Launcher: missing translations, translation bugs etc.

Hi, James,

As promised I made a list of missing / bugged translations, roughly in descending order of importance.

1. "< Back" button (everywhere).
   1.1. Does not use localized string anywhere but on Location tab.
   1.2. Does not expand to text width such as "< Назад"

2. Main page.
   2.1. Some sim options on the page have no localized names.
   2.2. If starting on airport's runway, "runway" is either:
   2.2.a. not removed from runway name if a runway is specified, if LocationController "on %1" is only meant for runways;
   2.2.b. not localized, otherwise.
   2.3. If starting with offset from some point, the N, E, S, W is not localized (maybe it's better to show heading instead, though?)
   2.4. <localized> -overlay.xml not picked up for <readable-name>, <description> etc. This is especially visible on presets with no readable-name hardcoded in launcher locale.</description></readable-name></localized>

3. Add-ons page: text in the end is out of scrolling range.

4. <localized> in -set.xml and addon-config.xml (and I expect catalog.xml but have not checked yet).
   4.1. Not picking up author and maintainer lists.
   4.2. (for -set.xml) not being used for loading screen.</localized>

5. Location page: units in offsets, speeds, altitudes and "°True" are not localized.

6. "Cancel" button (in all dialogs that pop up) is not localized. (Maybe it's trying to use system locale but failing -- because using "LC_ALL=ru_RU.UTF-8" did not work, as the inside of file selection dialogs stayed English)

7. Random things that I noticed.
   7.1. I noticed some inconsistencies in the original locale: please check the FIXME's in Russian locale's comment fields.
   7.2. Units selected in Location (such as km) are not used on the main page.
   7.3. Carrier selection has no option to spawn on catapult (maybe those features are not working yet, though?)

[James Turner]

7.3 is weird: I just tested and it's work fine here. When you select a carrier, don't you get the option to star on a carrier catapult / parking position?

[Anonymous]

Ah, sorry, I mean there's "On deck" but no "On catapult".

[James Turner]

Ah the problem is we don't know if the location is parking, lift, catapult, etc. Therefoere 'on deck' is the generic phrase I came up with.

[Anonymous]

Ok, then 7.3 doesn't exist. :)

[Anonymous]

James, I'm so sorry! I forgot one more thing: I found inconsistent punctuation and had a few questions about the meaning of some strings in the original locale: please grep Russian XLF files for "XXX" and "FIXME".

[James Turner]

Do you mean in the English originals? I don't normally go through the XLF files line by line when merging, so probably missed these. But, it's possible to add 'translation description messages' in the code, if a string is unclear.

[Anonymous]

In the merging code? Yes, it might work. Next time I'll remember to report them directly though. :)

[Anonymous]

I forgot one more: the "Okay" button in the blue first-run message.

[James Turner]

I've pushed fixes for these to next and 2020.3; of course it means some translation string updates.

Some are much harder to fix, I've done the easy ones for now.

[Anonymous]

I will update locales today.

Somehow, rn 2020.3 does not build:

ninja: error: '/home/mike/src/git/flightgear/flightgear/src/GUI/qml/ScrolledGridView.qml', needed by 'src/GUI/qrc_resources.cpp', missing and no known rule to make it

[James Turner]

I had a file-name typo, update now and it should be fixed.

[Anonymous]

Yay, it builds now!

Found a couple more:

1. In flight planner:
   1.1. "IFR" and "VFR" not localized;
   1.2. flight level still shows "ft" string when you click "metres" in the dropdown (but "FL" is fine);
   1.3. waypoint distance overflows to the right if translation for "nm" is too long (such as "миль");
   1.4. is "Estimated enroute time" right, or should it be "Estimated arrival time"?
2. Spelling of source "KHz" should be "kHz"

[James Turner]

Ouch, you are a tough guy to please ;)

Most of these I can fix quickly, except 1.4 might just be a 'not implemented yet'

Thanks for the feedback, even if it makes some work :)

[Anonymous]

I do nitpick sometimes, indeed -- I'm sorry! :)

The launcher is already looking amazing, thank you for working on it!

[James Turner]

No apology need, you're keeping me well behaved :)

And really it's more valuable than you realise: when you work on something closely, it's hard to step back and see what is missed. So having someone else look with care is really good. Mostly I am just kicking myself, that I didn't see it, before you did.

[Anonymous]

Good to know, thank you!

Question: does <localized><$LANG><urls> exist for -set.xml, or are urls always the same?

[Anonymous]

I don't know if this has appeared before, but now selecting the "Default" spawn state on the main page is not saved on quit. Only "Auto" or a particular state can be saved.

[Anonymous]

Also noticed that <name> (corresponding to <description> of -set.xml) from catalog.xml does not pick up <localized> unlike when installing without catalog.

[James Turner]

I didn't allow for locallizing URLs, but acdtually it's easy to add, will make a note.

The 'default' state bug, is probabyl a side effect; I was getting a bug where the wrong state was saved for default, so I added some validation on load, that the airfcraft actually has a state which matches theone we saved (otherwise we get a nasty erorr when clicking fly, about 'no such state <foobar>'.</foobar>

I guess I need to check the 'default state' logic a bit more.

[James Turner]

About localization of <name> in catalogs, that's becuase I assumed name would not need to be localzied, but of course that isn't true for non-Latin names, so I can also add it.</name>

[Anonymous]

I just noticed another small bug: somehow monospaced input fields still use typographic ligatures: try typing ffi into Additional Settings, it gets condensed into a ligature.

[James Turner]

Mono-spaced fiedls are actually just a regular input field, but using Courier as the font. There's ways to restrict the input format, see:

https://doc.qt.io/qt-5/qml-qtquick-textinput.html#inputMethodHints-prop

But I don't think any of those are sufficient, unfortunately.