#2184 canvas windows with not proportional decorations

[Slawek Mikula]

I've noticed that somehow canvas window decorations on some machines look not proportional. There is Red Griffin ATC addon which on screenshots shows that the close button is much bigger than it should (the same on my machine). In the same thread other person screenshot shows, that close button is right size.

[Slawek Mikula]

It's very low priority. If I have some time, i'll look into it. Maybe it is trivial on the other side.

[Slawek Mikula]

Simplest nasal code to reproduce is:

dlgWindow = canvas.Window.new([400, 200], "dialog").setTitle("test");
dlgWindow.show();
dlgWindow.clearFocus();

Fix for this in the attachment nonetheless it breaks API for WindowButton (right now it is only used in gui.nas file (fgdata grep)). But I think if this image (origin 19x19px) is resized without this code change maybe something wrong is in the canvas drawing code.

[Slawek Mikula]

Fix also in branch: https://sourceforge.net/u/slawekmikula/flightgear-fgdata/ci/fixes/tree/. Commit: https://sourceforge.net/u/slawekmikula/flightgear-fgdata/ci/a6d1be7d0129eb350309c9c34c366b4bf963c5e0/

[James Turner]

@slawekmikula Did this fix get merged?

[Slawek Mikula]

@jmturner AFAIK no. It hasn't been merged. This fix should do it with the mentioned "close" button.

But looking at the code i was wandering if there is something wrong with primitive canvas drawing (the "code" which renders this icon) and it could appear somewhere else. If noone was reporting something similar in eg. FG-1000 then maybe this is only here.

[Slawek Mikula]

I've seen this issue on other user's screens: https://forum.flightgear.org/viewtopic.php?f=4&t=36410&sid=ac7d931b8a1b8e96c85f2838ca16de9d&start=945#p375085 I think it is common to some graphics driver ? Don't know.

[Gijs]

@slawekmikula can you still reproduce this issue with current FG? It seems to work fine for me, without your fix...

[Gijs]

Assuming this has been fixed in the past 4 years. Please re-open if the issue still exists with a current version of FG.