#2064 Route Manager: Clear List no longer clears airports

[legoboyvdlp]

Clear List no longer clears airports.

https://i.imgur.com/L07GBoS.png

Pressing Clear List did not remove the waypoints. It merely deactivated the route manager.

I then set up the route manager with one intermediate waypoint (CLN) and activated: Clear List removed CLN, but did not remove the airports.

System: Win 10 Home 64 bit

[legoboyvdlp]

Sorry - didn't put it in right... label / owner incorrect!

[James Turner]

This is becuase they are entered as the departure and destination, so they are present automatically. Has this behaviour changed compared to previous versions? This was not intentional but what it does not feels correct to me.

[James Turner]

Is this still around? I though we added even a unit-test case for it...

[legoboyvdlp]

I just checked and its still around - clear list button only removed waypoints - it doesn't deselect airports or procedures.

https://media.discordapp.net/attachments/637292628181778452/725315041536245891/unknown.png

[James Turner]

Ah that's as designed: it's a 'clear waypoints' button, not a 'clear everything' button.

Does it make sense to change it to 'clear everything'? Either are fine.

[legoboyvdlp]

Clear list sounds as though it should clear the entire thing, yes -- there's also some potential confusion as it doesn't clear the waypoints of the procedures, only enroute waypoints.

[James Turner]

hmm, we discussed this on the devel list, but I forget what we agreed to do...

[legoboyvdlp]

There didn't seem to be a clear consensus, with one preference for renaming to "clear enroute" and two preferring modifying behaviour to clear everything.

[James Turner]

My current feeling is to make it clear everything /every/ : i.e replace the entire FLightPlan with a blank one. Jonathan, how do you feel about that?

[legoboyvdlp]

Absolutely, that sounds great - sorry for not getting back earlier, sourceforge is totally unusable on mobile!

[James Turner]

Nothing in life is ever simple! The dialog calls flightpan().cleanPlan(), which calls FlightPlan::clear().

I don't want to change the behaviour of Nasal flightplan::cleanPlan(), what I think I'll do is a add flightplan().reset(). I'll rename FlightPlan::clear in C++ to clearLegs(), and then make a new C++ clear() which clears everything.

This will keep any Nasal users of flightPlan.cleanPlan() happy (it will stil call clearLegs, so no behaviour change), and the dialog will clear everything by calling flightPlan.reset()

Sound okay? Happy with the names? Have I missed any ways this can break any existing aircraft?

[legoboyvdlp]

That sounds fine -- cleanPlan() will still do what it always did, so as the interface is the same it shouldn't break anything.

[Gijs]

Hi Jonathan and James, from the looks of it, this has never been pushed?

[James Turner]

I thoguht we fixes this long ago, hmm.

[Gijs]

Apparently not. The route manager dialog still calls flightplan().cleanPlan() , instead of flightplan().reset() (which doesn't exist) as suggested by your comment in https://sourceforge.net/p/flightgear/codetickets/2064/#9dff And I can confirm that the behavior reported by Jonathan is still there.

[Gijs]

Actually, I now see that it was committed in [a297c8], but the button in the route manager dialog was never changed to call the new flightplan().clearAll(). I've just pushed the final missing piece in [c54b23] after almost 4 years :-)